diff options
| author | W. J. van der Laan <laanwj@protonmail.com> | 2021-11-30 20:04:13 +0100 |
|---|---|---|
| committer | W. J. van der Laan <laanwj@protonmail.com> | 2021-11-30 20:05:44 +0100 |
| commit | c5712d172e92e231b8dc2828d4cf4bbbb8e86a16 (patch) | |
| tree | b7470e0117afd4ec4b8496b33ba51175146d84e9 /contrib/guix | |
| parent | 63c0d0e937afed7169c981a9b3a95e0fc5e44040 (diff) | |
| parent | a3f61676e83e908da67664c6163db61d1d11c5d2 (diff) | |
| download | bitcoin-c5712d172e92e231b8dc2828d4cf4bbbb8e86a16.tar.xz | |
Merge bitcoin/bitcoin#23506: test: Make more shell scripts verifiable by the `shellcheck` tool
a3f61676e83e908da67664c6163db61d1d11c5d2 test: Make more shell scripts verifiable by the `shellcheck` tool (Hennadii Stepanov)
Pull request description:
Some shell scripts from `contrib/guix` and `contrib/shell` are not verifiable by the `shellcheck` tool for the following reasons:
- they have no extension (see https://github.com/bitcoin/bitcoin/pull/21375/commits/4eccf063b252bfe256cf72d363a24cf0183e926e from bitcoin/bitcoin#21375)
- they have the `.bash` extension while `.sh` is expected
This PR adds these scripts to the input for the `shellcheck` tool, and it fixes discovered `shellcheck` warnings.
ACKs for top commit:
dongcarl:
Code Review ACK a3f61676e83e908da67664c6163db61d1d11c5d2, this is a good robustness improvement for our shell scripts.
jamesob:
crACK https://github.com/bitcoin/bitcoin/pull/23506/commits/a3f61676e83e908da67664c6163db61d1d11c5d2
Tree-SHA512: 6703f5369d9c04c1a174491f381afa5ec2cc4d37321c1b93615abcdde4dfd3caae82868b699c25b72132d8c8c6f2e9cf24d38eb180ed4d0f0584d8c282e58935
Diffstat (limited to 'contrib/guix')
| -rw-r--r-- | contrib/guix/libexec/prelude.bash | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/contrib/guix/libexec/prelude.bash b/contrib/guix/libexec/prelude.bash index 40ae4b5208..1f287e9bbb 100644 --- a/contrib/guix/libexec/prelude.bash +++ b/contrib/guix/libexec/prelude.bash @@ -2,10 +2,10 @@ export LC_ALL=C set -e -o pipefail -# shellcheck source=../../shell/realpath.bash +# shellcheck source=contrib/shell/realpath.bash source contrib/shell/realpath.bash -# shellcheck source=../../shell/git-utils.bash +# shellcheck source=contrib/shell/git-utils.bash source contrib/shell/git-utils.bash ################ |