diff options
| author | Wladimir J. van der Laan <laanwj@protonmail.com> | 2020-03-25 15:32:39 +0100 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@protonmail.com> | 2020-03-25 15:35:36 +0100 |
| commit | 3e50fdbe4e5bb98194e88023468bd77dee78b26e (patch) | |
| tree | 17959afb6b206fcfb9c00c286d36d245167df30d /contrib/gitian-descriptors | |
| parent | 244e88e6b580f94434d16b2cea2e5690db24f0d4 (diff) | |
| parent | 1a0993ae354c36d6f219e67f82ca8236530d6201 (diff) | |
| download | bitcoin-3e50fdbe4e5bb98194e88023468bd77dee78b26e.tar.xz | |
Merge #18395: scripts: add PE dylib checking to symbol-check.py
1a0993ae354c36d6f219e67f82ca8236530d6201 scripts: add PE dylib checking to symbol-check.py (fanquake)
Pull request description:
Uses `objdump -x` and looks for `DLL Name:` lines. i.e:
```bash
objdump -x src/qt/bitcoin-qt.exe | grep "DLL Name:"
DLL Name: ADVAPI32.dll
DLL Name: dwmapi.dll
DLL Name: GDI32.dll
DLL Name: IMM32.dll
DLL Name: IPHLPAPI.DLL
DLL Name: KERNEL32.dll
DLL Name: msvcrt.dll
DLL Name: ole32.dll
DLL Name: OLEAUT32.dll
DLL Name: SHELL32.dll
DLL Name: SHLWAPI.dll
DLL Name: USER32.dll
DLL Name: UxTheme.dll
DLL Name: VERSION.dll
DLL Name: WINMM.dll
DLL Name: WS2_32.dll
```
ACKs for top commit:
dongcarl:
Concept ACK 1a0993ae354c36d6f219e67f82ca8236530d6201
hebasto:
ACK 1a0993ae354c36d6f219e67f82ca8236530d6201, tested on Linux Mint 19.3:
Tree-SHA512: 0099a50e2c616d5239a15cafa9a7c483e9c40244af41549e4738be0f5360f27a2afb956eb50b47cf446b242f4cfc6dc9d111306a056fb83789eefbd71eddabd2
Diffstat (limited to 'contrib/gitian-descriptors')
| -rw-r--r-- | contrib/gitian-descriptors/gitian-win.yml | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/contrib/gitian-descriptors/gitian-win.yml b/contrib/gitian-descriptors/gitian-win.yml index e3c1ea737f..c5eea97c77 100644 --- a/contrib/gitian-descriptors/gitian-win.yml +++ b/contrib/gitian-descriptors/gitian-win.yml @@ -138,6 +138,7 @@ script: | CONFIG_SITE=${BASEPREFIX}/${i}/share/config.site ./configure --prefix=/ --disable-ccache --disable-maintainer-mode --disable-dependency-tracking ${CONFIGFLAGS} CFLAGS="${HOST_CFLAGS}" CXXFLAGS="${HOST_CXXFLAGS}" make ${MAKEOPTS} make ${MAKEOPTS} -C src check-security + make ${MAKEOPTS} -C src check-symbols make deploy make install DESTDIR=${INSTALLPATH} cp -f --target-directory="${OUTDIR}" ./bitcoin-*-setup-unsigned.exe |