diff options
| author | Wladimir J. van der Laan <laanwj@gmail.com> | 2019-03-14 18:57:32 +0100 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@gmail.com> | 2019-03-14 18:58:43 +0100 |
| commit | 7fa1f6258c05648f901d7135f8b6606f60428e70 (patch) | |
| tree | 338f6d14ba2bb73c7f5bc6cc798b7d5abd990f0a /contrib/gitian-descriptors | |
| parent | 8e1704c01537d1750555de23bfae00efa5864b3e (diff) | |
| parent | 15c69b158da570f4e1430280c610e94ffdee0e51 (diff) | |
| download | bitcoin-7fa1f6258c05648f901d7135f8b6606f60428e70.tar.xz | |
Merge #15583: wallet: Log and ignore errors in ListWalletDir and IsBerkeleyBtree
15c69b158da570f4e1430280c610e94ffdee0e51 wallet: Log and ignore errors in ListWalletDir and IsBerkeleyBtree (João Barbosa)
Pull request description:
Use the `noexcept` members of `boost::filesystem::recursive_directory_iterator` in order to ignore `boost::filesystem::directory_iterator::construct: Permission denied` errors. The errors are logged though.
Steps to reproduce the issue:
```sh
# 1. create directory for -walletdir without read access:
mkdir /tmp/foo && chmod a-r /tmp/foo
# 2. run bitcoin-qt and should print an error, but continues running:
/Volumes/Bitcoin-Core/Bitcoin-Qt.app/Contents/MacOS/Bitcoin-Qt -regtest -walletdir=/tmp/foo
/private/tmp/foo: Permission denied
# 4. go to File -> Open Wallet and should segfault:
EXCEPTION: N5boost10filesystem16filesystem_errorE
boost::filesystem::directory_iterator::construct: Permission denied: "/private/tmp/foo"
bitcoin in Runaway exception
```
Tree-SHA512: 37e8bf5a1e0defc331030fd511bf9cac2765d01dfbf23e7233f37506e85b8ad07edcde9ba6dae7a2c95700c78d28c7dd248153607381852da96273cb159c4934
Diffstat (limited to 'contrib/gitian-descriptors')
0 files changed, 0 insertions, 0 deletions