diff options
| author | Wladimir J. van der Laan <laanwj@gmail.com> | 2019-03-09 06:45:09 +0100 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@gmail.com> | 2019-03-09 06:45:19 +0100 |
| commit | 12408d33c6ac85522a0751908230cb0f3b4078fc (patch) | |
| tree | 0643304f40899e66dcfeafe3ec09ca7f59ba7e66 /contrib/gitian-descriptors/gitian-win-signer.yml | |
| parent | efed9809b4fab34e33c3012aa3cf4b7a75d98ead (diff) | |
| parent | 32da92bdf6bb55d6d312b0f85797d439cc942db5 (diff) | |
| download | bitcoin-12408d33c6ac85522a0751908230cb0f3b4078fc.tar.xz | |
Merge #15549: gitian: Improve error handling
32da92bdf6bb55d6d312b0f85797d439cc942db5 gitian: Improve error handling (Wladimir J. van der Laan)
Pull request description:
Improve error handling in gitian builds:
- Set fail-on-error and pipefail flag, this causes a command to fail when either of the pipe stages fails, not only when the last of the stages fails, so this improves error detection.
- Also use `xargs` instead of `find -exec`, because `find` will not propagate errors in the executed command, but `xargs` will.
This will avoid some issues like #15541 where non-determinism is silently introduced due to errors caused by environment conditions (such as lack of disk space in that case).
Tree-SHA512: d5d3f22ce2d04a75e5c25e935744327c3adc704c2d303133f2918113573a564dff3d3243d5569a2b93ee7eb0e97f8e1b1ba81767e966af9015ea711a14091035
Diffstat (limited to 'contrib/gitian-descriptors/gitian-win-signer.yml')
| -rw-r--r-- | contrib/gitian-descriptors/gitian-win-signer.yml | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/contrib/gitian-descriptors/gitian-win-signer.yml b/contrib/gitian-descriptors/gitian-win-signer.yml index 045be873e9..08d20177a6 100644 --- a/contrib/gitian-descriptors/gitian-win-signer.yml +++ b/contrib/gitian-descriptors/gitian-win-signer.yml @@ -16,6 +16,8 @@ files: - "osslsigncode-Backports-to-1.7.1.patch" - "bitcoin-win-unsigned.tar.gz" script: | + set -e -o pipefail + BUILD_DIR=`pwd` SIGDIR=${BUILD_DIR}/signature/win UNSIGNED_DIR=${BUILD_DIR}/unsigned |