diff options
author | MarcoFalke <falke.marco@gmail.com> | 2018-05-05 10:32:19 -0400 |
---|---|---|
committer | MarcoFalke <falke.marco@gmail.com> | 2018-05-05 10:32:32 -0400 |
commit | 66cc47be982aa431b72494f5d655c20eea17a0f5 (patch) | |
tree | 37a7f16a114cde0d2fc65dafa5afa72deafb957e /contrib/devtools | |
parent | f82e1c94821212cc8962775a7a29599ebd92eee0 (diff) | |
parent | cbba1d2da42a9c813c50ea3b3c13ec9a518bc147 (diff) |
Merge #13080: mempool: Add compile time checking for ::mempool.cs runtime locking assertions
cbba1d2da4 Add compile time checking for all ::mempool.cs runtime locking assertions (practicalswift)
Pull request description:
Add compile time checking for `::mempool.cs` runtime locking assertions.
This PR is a subset of #12665. The PR was broken up to make reviewing easier.
The intention is that literally all `EXCLUSIVE_LOCKS_REQUIRED`/`LOCKS_EXCLUDED`:s added in this PR should follow either directly or indirectly from `AssertLockHeld(…)`/`AssertLockNotHeld(…)`:s already existing in the repo.
Consider the case where function `A(…)` contains `AssertLockHeld(cs_foo)` (without
first locking `cs_foo` in `A`), and that `B(…)` calls `A(…)` (without first locking `cs_main`):
* It _directly_ follows that: `A(…)` should have an `EXCLUSIVE_LOCKS_REQUIRED(cs_foo)` annotation.
* It _indirectly_ follows that: `B(…)` should have an `EXCLUSIVE_LOCKS_REQUIRED(cs_foo)` annotation.
Tree-SHA512: 1b5ec1cfca6be67edd1298fea1a52b5572ce833dd4ad05c4583f753c2d3229402663373675df87e950151d5c41aeb3ee02f0ad935ed83fe2f45ca8e4d55d901e
Diffstat (limited to 'contrib/devtools')
0 files changed, 0 insertions, 0 deletions