diff options
| author | fanquake <fanquake@gmail.com> | 2020-05-07 15:17:16 +0800 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2020-05-07 15:41:59 +0800 |
| commit | 3b1e289248dcda896aaa1c84995ee9c6077601e6 (patch) | |
| tree | 485a96e2c039e971e63869e432b08cf54a98962e /configure.ac | |
| parent | 7bcc42b4035b878719d13201286e322989b415c5 (diff) | |
| parent | a029805f57fa9a4ab9867c0d1e865675d57537c7 (diff) | |
| download | bitcoin-3b1e289248dcda896aaa1c84995ee9c6077601e6.tar.xz | |
Merge #18535: build: remove -Qunused-arguments workaround for clang + ccache
a029805f57fa9a4ab9867c0d1e865675d57537c7 build: remove -Qunused-arguments workaround for clang + ccache (fanquake)
Pull request description:
This was added in 386efb7695debaf5f0f328a2e4c9abc342161665 to address spammy Clang warnings when building with ccache.
The issue was addressed in [ccache 3.2](https://bugzilla.samba.org/show_bug.cgi?id=8118), and from a look at most major distros, it's only Debian Jessie that has a version of ccache older than that ([3.1](https://packages.debian.org/jessie/ccache)).
Therefore I think it's acceptable to drop this workaround, and re-enable warnings for unused driver arguments (when compiling using Clang and ccache).
ACKs for top commit:
hebasto:
ACK a029805f57fa9a4ab9867c0d1e865675d57537c7.
vasild:
utACK a029805f57fa9a4ab9867c0d1e865675d57537c7
Tree-SHA512: f887b9bd12f9c1c8d209943b86e8dafe33cfd1572912f2cafabe08ffe403973e48f0f7289280a8c6db9263c57aad43fbd4bb72f42db762eb090f3b1ef0538f43
Diffstat (limited to 'configure.ac')
| -rw-r--r-- | configure.ac | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/configure.ac b/configure.ac index fca2038062..cf04faf6d1 100644 --- a/configure.ac +++ b/configure.ac @@ -1468,9 +1468,6 @@ if test "x$use_ccache" != "xno"; then fi AC_MSG_RESULT($use_ccache) fi -if test "x$use_ccache" = "xyes"; then - AX_CHECK_PREPROC_FLAG([-Qunused-arguments],[CPPFLAGS="-Qunused-arguments $CPPFLAGS"]) -fi dnl enable wallet AC_MSG_CHECKING([if wallet should be enabled]) |