diff options
| author | fanquake <fanquake@gmail.com> | 2022-02-09 21:40:53 +0000 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2022-02-09 21:41:36 +0000 |
| commit | 8c0f02c69d50761c3a6d4dfb5d7cba43a00a55ae (patch) | |
| tree | c6d0ad8089d2447f09e58b06acfab9ca350eaeca /configure.ac | |
| parent | 5e8e0b3d7f6055e326bda61e60712b530e8920f0 (diff) | |
| parent | ebda2b8c819d989327c6b3e29237dfb43628e647 (diff) | |
| download | bitcoin-8c0f02c69d50761c3a6d4dfb5d7cba43a00a55ae.tar.xz | |
Merge bitcoin/bitcoin#24265: Drop StripRedundantLastElementsOfPath() function
ebda2b8c819d989327c6b3e29237dfb43628e647 util: Drop no longer needed StripRedundantLastElementsOfPath() function (Hennadii Stepanov)
ecd094e2b1e1eb7dba24dafef3640a9b6cc55f82 Use ArgsManager::GetPathArg() for "-walletdir" option (Hennadii Stepanov)
06fed4c21ec64cd224231d15cbbeb985b8fba5f2 Use ArgsManager::GetPathArg() for "-blocksdir" option (Hennadii Stepanov)
15b632bf169f6272ca90faba8d8036e3e822542f Use ArgsManager::GetPathArg() for "-datadir" option (Hennadii Stepanov)
540ca5111f7dc91a9808e41ccb4446d8dc0a1bec util: Add ArgsManager::GetPathArg() function (Hennadii Stepanov)
Pull request description:
[Switching](https://github.com/bitcoin/bitcoin/pull/20744) to `std::filesystems` makes possible to leverage [`std::filesystem::path::lexically_normal`](https://en.cppreference.com/w/cpp/filesystem/path/lexically_normal) and get rid of ugly `StripRedundantLastElementsOfPath()` crutch.
To make its usage simple and error-proof, a new `ArgsManager::GetPathArg()` member function introduced which guarantees to return a normalized with no trailing slashes paths provided via `-datadir`, `-blocksdir` or `-walletdir` command-line arguments or configure options.
ACKs for top commit:
ryanofsky:
Code review ACK ebda2b8c819d989327c6b3e29237dfb43628e647. Only change since last review is rebase which simplified the last commit
Tree-SHA512: ed86959b6038b7152b5a1d473478667b72caab1716cc9149e1a75833d50511f22157e4e5e55a9465d1fa76b90bce5e5286f4e4f0d1ae65ebd9c012fae19d835f
Diffstat (limited to 'configure.ac')
0 files changed, 0 insertions, 0 deletions