diff options
| author | MacroFake <falke.marco@gmail.com> | 2022-06-15 08:13:56 +0200 |
|---|---|---|
| committer | MacroFake <falke.marco@gmail.com> | 2022-06-15 08:14:02 +0200 |
| commit | ede90890969152b5c13ea21e57490fcb8d5c3b70 (patch) | |
| tree | ccc7486e1632476b2391e1aed1e19f8afe835002 /ci | |
| parent | 38c63e3683746774d3ddc60e32aa33af20573473 (diff) | |
| parent | fafddafc2c60c7a176c5367967181cc1cabf3196 (diff) | |
Merge bitcoin/bitcoin#25156: refactor: Introduce PeerManagerImpl::RejectIncomingTxs
fafddafc2c60c7a176c5367967181cc1cabf3196 refactor: Introduce PeerManagerImpl::RejectIncomingTxs (MacroFake)
Pull request description:
Currently there are some confusions in net_processing:
* There is confusion between `-blocksonly mode` and `block-relay-only`, so adjust all comments to use the same nomenclature.
* Whether to disconnect peers for providing invs/txs is implemented differently. For example, it seems a bit confusing to disconnect `block-relay-only` peers with `relay` permission when they send a tx message, but not when they send an inv message. Also, keeping track of their inv announcements seems both wasteful and confusing, as it does nothing. This isn't possible in practice, as outbound connections do not have permissions assigned, but sees fragile to rely on. Especially in light of proposed changes to make that possible: https://github.com/bitcoin/bitcoin/pull/17167
ACKs for top commit:
MarcoFalke:
Should be trivial to re-ACK with `git range-diff bitcoin-core/master fa2b5fe0c1 fafddafc2c`.
jnewbery:
Code review ACK fafddafc2c
mzumsande:
ACK fafddafc2c60c7a176c5367967181cc1cabf3196
Tree-SHA512: 73bf91afe93be619169cfbf3bf80cb08a5e6f73df4e0318b86817bd4d45f67408ea85998855992281d2decc9d24f7d75cffb83a0518d670090907309df8a3490
Diffstat (limited to 'ci')
0 files changed, 0 insertions, 0 deletions