diff options
| author | fanquake <fanquake@gmail.com> | 2021-10-16 08:18:05 +0800 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2021-10-16 08:18:49 +0800 |
| commit | feedb9c84e72e4fff489810a2bbeec09bcda5763 (patch) | |
| tree | dbda87f26272b0e268aa5d960737b365fc5f117d /ci | |
| parent | 02ccf1086ea02635d59282e5dd2b3eeb35484753 (diff) | |
| parent | ca2c313aa291ae44adc1b7148ed49125bdc77bf4 (diff) | |
| download | bitcoin-feedb9c84e72e4fff489810a2bbeec09bcda5763.tar.xz | |
Merge bitcoin/bitcoin#23268: p2p: Use absolute FQDN for DNS seed domains
ca2c313aa291ae44adc1b7148ed49125bdc77bf4 Use absolute FQDN for DNS seed domains (Prayank)
Pull request description:
Fixes https://github.com/bitcoin/bitcoin/issues/23193 by using absolute FQDN for domains used by DNS seeds.
It improves security and should not break anything based on my research and testing. Few things about absolute FQDN are shared in https://superuser.com/questions/1467958/why-does-putting-a-dot-after-the-url-remove-login-information
Master branch:
```
DNS seed x9.dnsseed.bitcoin.dashjr.org. responded with IP 127.0.0.1
```
PR branch:
```
DNS seed x9.dnsseed.bitcoin.dashjr.org. responded with IP 159.89.108.149
```
Reviewers can follow the steps mentioned in Issue to test: https://github.com/bitcoin/bitcoin/issues/23193#issuecomment-937717145
ACKs for top commit:
practicalswift:
cr ACK ca2c313aa291ae44adc1b7148ed49125bdc77bf4
laanwj:
code review ACK ca2c313aa291ae44adc1b7148ed49125bdc77bf4
promag:
Code review ACK ca2c313aa291ae44adc1b7148ed49125bdc77bf4.
Tree-SHA512: 9818227332282a78c45b4470c2fc80bf899ed78aed76644ebf014e0fff1b139402ea023acdea162363a478b6f6613dbf1da57e214d2240ea0f04310473f57cca
Diffstat (limited to 'ci')
0 files changed, 0 insertions, 0 deletions