diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2020-04-30 09:30:01 -0400 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2020-04-30 09:30:13 -0400 |
| commit | a66ba6d029b3948dec0cf092bb844f70c16b07dc (patch) | |
| tree | ad5af67f64761ec1a43d7afc57cc709944536b88 /ci | |
| parent | 00c1a4d9a95eaead64508ee2a7625bdc67e65fa3 (diff) | |
| parent | de8905adf204c42bba810802f82b98f7b3dd26dc (diff) | |
Merge #18576: test: use unittest for test_framework unit testing
de8905adf204c42bba810802f82b98f7b3dd26dc test: use unittest and test_runner for test framework unit testing (Gloria Zhao)
Pull request description:
Proposal for unit testing on test_framework functions:
1. Use the python `unittest` library. Don't use test_framework to test itself.
2. Put the tests inside the same file as the functions they are testing.
3. Call the tests from `test_runner.py`. To include more Test Framework tests, add the filename to the list `TEST_FRAMEWORK_MODULES`. Don't add new files or change the list of accepted script prefixes.
Makes these changes for `bn2vch` (followup to [this comment](https://github.com/bitcoin/bitcoin/pull/18378#pullrequestreview-377271264)).
ACKs for top commit:
jnewbery:
Tested ACK de8905adf204c42bba810802f82b98f7b3dd26dc. Great stuff gzhao408 . Thanks for this!
Tree-SHA512: 91572d43e203a1864765b93a9472667994115ec38b271f2b2f9fcd0f0112b393fc24ba7d2371d5a34b0a6a4522f6b934fc5164363819aa7ed8d6c6c9a60cc101
Diffstat (limited to 'ci')
0 files changed, 0 insertions, 0 deletions