diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2019-09-25 13:14:16 -0400 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2019-09-25 13:14:22 -0400 |
| commit | 4c4ff4911a6dbf1555fb4cfc05092cb8fe2f9eba (patch) | |
| tree | b620ab1e0e7aaa0d24be290f913518059ff494f1 /ci | |
| parent | ae3902ee3f3e4ea21c2a19470d402e418965b8ef (diff) | |
| parent | f4beb4996d27f2cdaf4f0a63e7dc044bf17decce (diff) | |
| download | bitcoin-4c4ff4911a6dbf1555fb4cfc05092cb8fe2f9eba.tar.xz | |
Merge #16961: test: Remove python dead code linter
f4beb4996d27f2cdaf4f0a63e7dc044bf17decce test: Remove python dead code linter (Wladimir J. van der Laan)
Pull request description:
Primarily I'd like to remove this because it is very imprecise, due to Python's dynamic nature, giving it a large list of false positives that need to be listed as exceptions. See for example #16906.
It's also a frequent source of complaints. I'm doubtful of the usefulness of checking for dead code in a linter in the first place.
Having some dead code in the test framework for a while is not a
disaster.
ACKs for top commit:
sdaftuar:
utACK f4beb4996d27f2cdaf4f0a63e7dc044bf17decce
practicalswift:
ACK f4beb4996d27f2cdaf4f0a63e7dc044bf17decce -- diff looks correct
jamesob:
ACK https://github.com/bitcoin/bitcoin/pull/16961/commits/f4beb4996d27f2cdaf4f0a63e7dc044bf17decce
Tree-SHA512: 329b1555210311d5d15799fd2cb794b3208b0ac4d8a2ffaf4dece1bcc3e0e8b1fe952d5e7a394f94a98919cab579fb579eae7db2a796cc9a1a42ef495dd17507
Diffstat (limited to 'ci')
| -rwxr-xr-x | ci/lint/04_install.sh | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/ci/lint/04_install.sh b/ci/lint/04_install.sh index 6c3019a1aa..12c3bfce45 100755 --- a/ci/lint/04_install.sh +++ b/ci/lint/04_install.sh @@ -8,7 +8,6 @@ export LC_ALL=C travis_retry pip3 install codespell==1.15.0 travis_retry pip3 install flake8==3.7.8 -travis_retry pip3 install vulture==1.0 SHELLCHECK_VERSION=v0.6.0 curl -s "https://storage.googleapis.com/shellcheck/shellcheck-${SHELLCHECK_VERSION}.linux.x86_64.tar.xz" | tar --xz -xf - --directory /tmp/ |