diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2021-05-19 21:01:21 +0200 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2021-05-19 21:01:29 +0200 |
| commit | ff438a1966e952e548574552f2ed4c17a7432bb0 (patch) | |
| tree | 9a980e84ec481eadb5eb7738917d2ada83066dfe /ci/test/06_script_b.sh | |
| parent | d4c409cf09d02d3978b590ebdc55ff50f9938d3e (diff) | |
| parent | 39393479c514f271c42750ffcd0adc6bc1db2e2f (diff) | |
Merge bitcoin/bitcoin#21996: p2p: pass strings to NetPermissions::TryParse functions by const ref
39393479c514f271c42750ffcd0adc6bc1db2e2f p2p: pass strings to NetPermissions::TryParse functions by const ref (Jon Atack)
Pull request description:
instead of by value, as these are "in" params that are not cheap to copy.
Reference: https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#f16-for-in-parameters-pass-cheaply-copied-types-by-value-and-others-by-reference-to-const
ACKs for top commit:
MarcoFalke:
cr ACK 39393479c514f271c42750ffcd0adc6bc1db2e2f
Tree-SHA512: 294fe0f2d900293b4447d4e1f0ccc60c1ed27b3bdbd0f5d71d3dbf71de86879638b1b813fadfb44c58b4acff4e7d75b7ed6a4f9cc5fcf627108224e6a21b524c
Diffstat (limited to 'ci/test/06_script_b.sh')
0 files changed, 0 insertions, 0 deletions