diff options
| author | Wladimir J. van der Laan <laanwj@protonmail.com> | 2020-12-03 14:36:40 +0100 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@protonmail.com> | 2020-12-03 14:36:51 +0100 |
| commit | 3fa6a9fc8c9096cc207b11f52e63aa01550dce26 (patch) | |
| tree | d04fa193b850dfecc8e68f539cc44833e04e5d0a /ci/lint | |
| parent | a3186b6da60e1f76d0b097644241720783cd38a1 (diff) | |
| parent | 2c69381f3de5091e103cb8bef299aba321503e7c (diff) | |
| download | bitcoin-3fa6a9fc8c9096cc207b11f52e63aa01550dce26.tar.xz | |
Merge #20506: ci: AppVeyor fixes for Visual Studio 2019 16.8.1 image
2c69381f3de5091e103cb8bef299aba321503e7c Removed redundant git pull from appveyor config. (Aaron Clauson)
8b99e609e7da5dd3601e9214d8f869e96108fffe Adjusted msvc compiler and linker settings to remove optimisations that are causing sporadic ABI issues on Visual Studio updates. (Aaron Clauson)
Pull request description:
The motivation for this PR is twofold:
1. Update the Qt binaries used by the appveyor CI job after a recent update to Visual Studio 2019 used in the Appveyor build image resulted in ABI incompatibilities,
2. Remove optimisations and debug information from the Bitcoin Core `Release` msvc build to reduce the chance of future ABI incompatibility issues for future Visual Studio updates.
The changes made in this PR are:
- Changed appveyor config file hash to use a new version of Qt pre-compiled binaries built for Visual Studio 2019 v16.8.1.
- Adjusted msvc compiler and linker settings to remove optimisations and debug information generation to help avoid future ABI issues on Visual Studio updates.
- Tidied up debug and release configuration blocks in common project file to avoid duplication.
- Updated appveyor config to use latest Visual Studio 2019 image.
- Bumped vcpkg version to tag `2020.11-1` for binary caching feature*.
See #20392 for related discussion.
*Binary caching is a new [vcpkg feature](https://github.com/microsoft/vcpkg/blob/master/docs/specifications/binarycaching.md) that allows dependency caching. This PR is not using the feature but by updating the vcpkg version it means it can be optionally used by other contributors in their own Appveyor configs. By caching the vcpkg dependencies using this feature my build times are reduced by approx 10 minutes.
ACKs for top commit:
MarcoFalke:
Concept ACK 2c69381f3de5091e103cb8bef299aba321503e7c
laanwj:
Concept ACK 2c69381f3de5091e103cb8bef299aba321503e7c
Tree-SHA512: 372f5b8b3b5f7e56b78045f9fc06a22fd9f5366d06e99e2f1eaad6d741680da74d0e6371e7bc580cb41f4d6696b2101b950167309d33e98242578b458ace813a
Diffstat (limited to 'ci/lint')
0 files changed, 0 insertions, 0 deletions