diff options
| author | MacroFake <falke.marco@gmail.com> | 2022-05-02 14:14:51 +0200 |
|---|---|---|
| committer | MacroFake <falke.marco@gmail.com> | 2022-05-02 14:14:58 +0200 |
| commit | 5c93fc188d61cb64db91e6a0b9a98579974fa31d (patch) | |
| tree | 7f7e9471323f96170205c4432f42aee6e6bfcc44 /ci/README.md | |
| parent | e389c4d30881db4d115aeb700d0a22c2859ba9fe (diff) | |
| parent | e5485e8e4be7f2ee0671f58c3dcce35c68ba0ee0 (diff) | |
| download | bitcoin-5c93fc188d61cb64db91e6a0b9a98579974fa31d.tar.xz | |
Merge bitcoin/bitcoin#25017: validation: make CScriptCheck and prevector swap members noexcept
e5485e8e4be7f2ee0671f58c3dcce35c68ba0ee0 test, bench: make prevector and checkqueue swap member functions noexcept (Jon Atack)
abc1ee509025d92db5311c3f5df3b61c09cad24f validation: make CScriptCheck and prevector swap member functions noexcept (Jon Atack)
Pull request description:
along with those seen elsewhere in the codebase (prevector and checkqueue units/fuzz/bench).
A swap must not fail; when a class has a swap member function, it should be declared noexcept.
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#c84-a-swap-function-must-not-fail
ACKs for top commit:
pk-b2:
ACK https://github.com/bitcoin/bitcoin/pull/25017/commits/e5485e8e4be7f2ee0671f58c3dcce35c68ba0ee0
w0xlt:
ACK https://github.com/bitcoin/bitcoin/pull/25017/commits/e5485e8e4be7f2ee0671f58c3dcce35c68ba0ee0
Tree-SHA512: c82359d5e13f9262ce45efdae9baf71e41ed26568e0aff620e2bfb0ab37a62b6d56ae9340a28a0332c902cc1fa87da3fb72d6f6d6f53a8b7e695a5011f71f7f1
Diffstat (limited to 'ci/README.md')
0 files changed, 0 insertions, 0 deletions