diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2020-10-02 17:07:29 +0200 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2020-10-02 17:07:35 +0200 |
| commit | 171cd05ae3413e18fd6382572c86f2bb21ab2fd9 (patch) | |
| tree | 4b78357634c5812cc4656fcc1031cc6eb09b4e1d /ci/README.md | |
| parent | d9935222d53a2a625da992ca51cce7b79d78ca9a (diff) | |
| parent | c1585bca8dae01dee6a1dd8eadae2f8b100503df (diff) | |
Merge #20034: test: Get rid of default wallet hacks
c1585bca8dae01dee6a1dd8eadae2f8b100503df test: Get rid of default wallet hacks (Russell Yanofsky)
ed3acda33b75d1b546ee696a63def239bcdd62de test, refactor: add default_wallet_name and wallet_data_filename variables (Russell Yanofsky)
Pull request description:
Changes:
- Get rid of setup_nodes (`-wallet`, `-nowallet`, `-disablewallet`) argument rewriting
- Get rid of hardcoded wallet `""` names and `-wallet=""` args
Motivation:
- Simplify test framework behavior so it's easier to write new tests without having arguments mangled by the framework
- Make tests more readable, replacing unexplained `""` string literals with `default_wallet_name` references
- Make it trivial to update default wallet name and wallet data filename for sqlite #19077 testing
- Stop relying on `-wallet` arguments to create wallets, so it is easy to change `-wallet` option in the future to only load existing wallets not create new ones (to avoid accidental wallet creation, and encourage use of wallet encryption and descriptor features)
ACKs for top commit:
MarcoFalke:
ACK c1585bca8dae01dee6a1dd8eadae2f8b100503df, only effective change is adding documentation 🎵
Tree-SHA512: f62dec7cbdacb5f330aa0e1eec89ab4d065540d91495bbedcb375eda1c080b45ce9edb310ce253c44c4839f1b4cc2c7df9816c58402d5d43f94a437e301ea8bc
Diffstat (limited to 'ci/README.md')
0 files changed, 0 insertions, 0 deletions