diff options
| author | fanquake <fanquake@gmail.com> | 2021-09-08 14:53:25 +0800 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2021-09-08 15:17:42 +0800 |
| commit | 7d7d5e8efde944565be0d3eb25ed5a5279b8dabe (patch) | |
| tree | 6186484226cf029d43b523ff6dbc497755aefe8a /build_msvc | |
| parent | ecf580e40f607091a5e5d5fff9865237e037ea7f (diff) | |
| parent | fab0b55cf060c2b14fae5cee13f0a2dcaebde892 (diff) | |
| download | bitcoin-7d7d5e8efde944565be0d3eb25ed5a5279b8dabe.tar.xz | |
Merge bitcoin/bitcoin#22879: addrman: Fix format string in deserialize error
fab0b55cf060c2b14fae5cee13f0a2dcaebde892 addrman: Fix format string in deserialize error (MarcoFalke)
facce4ca44bc206b7656e297a7fa5dfb83a01012 test: Remove useless overwrite (MarcoFalke)
Pull request description:
The format string is evaluated differently on modern compilers (clang 10 and later, as well as gcc 10 and later).
Work around the behaviour change in compilers by pinning the underlying type of the format arguments.
Can be tested by observing a failing test when running against master compiled with clang 10 or gcc 10 (or later).
ACKs for top commit:
jonatack:
ACK fab0b55cf060c2b14fae5cee13f0a2dcaebde892 verified the test fails on master as expected only at line 61 (assertion fixed by the code change); the last two test additions pass as expected
mzumsande:
ACK fab0b55cf060c2b14fae5cee13f0a2dcaebde892
Tree-SHA512: 07462901435107f3bc79098fd7d06446bfe8fe065fffdd35adfcba8f1dd3c499575006557afe7bc74b79d690c5ef7b58e3e031e908161be5529cf237e3b30609
Diffstat (limited to 'build_msvc')
0 files changed, 0 insertions, 0 deletions