diff options
| author | Ava Chow <github@achow101.com> | 2024-01-23 15:07:43 -0500 |
|---|---|---|
| committer | Ava Chow <github@achow101.com> | 2024-01-23 15:14:03 -0500 |
| commit | 874c8bdb9e3c932f95bc9be60cb93a85a11ef480 (patch) | |
| tree | 8b28efd43421d87903f982474fdc81d2272e82ec /build_msvc | |
| parent | 6f732ffc3c919ede171f419197cb1e00afadf1d1 (diff) | |
| parent | e9014042a6bed8c16cc9a31fc35cb709d4b3c766 (diff) | |
Merge bitcoin/bitcoin#29144: init: handle empty settings file gracefully
e9014042a6bed8c16cc9a31fc35cb709d4b3c766 settings: add auto-generated warning msg for editing the file manually (furszy)
966f5de99a9f5da05c91378ad1e8ea8ed37ac3b3 init: improve corrupted/empty settings file error msg (furszy)
Pull request description:
Small and simple issue reported [here](https://community.umbrel.com/t/bitcoin-docker-container-keeps-restarting/2144).
Improving a confusing situation reported by users who did not understand why a
settings parsing error occurred when the file was empty and did not know how to solve it.
Empty setting file could be due (1) corruption or (2) an user manually cleaning up the file content.
In both scenarios, the 'Unable to parse settings file' error does not help the user move forward.
ACKs for top commit:
achow101:
ACK e9014042a6bed8c16cc9a31fc35cb709d4b3c766
hebasto:
re-ACK e9014042a6bed8c16cc9a31fc35cb709d4b3c766.
ryanofsky:
Code review ACK e9014042a6bed8c16cc9a31fc35cb709d4b3c766. Just whitespace formatting changes and shortening a test string literal since last review
shaavan:
Code review ACK e9014042a6bed8c16cc9a31fc35cb709d4b3c766
Tree-SHA512: 2910654c6b9e9112de391eedb8e46980280f822fa3059724dd278db7436804dd27fae628d2003f2c6ac1599b07ac5c589af016be693486e949f558515e662bec
Diffstat (limited to 'build_msvc')
0 files changed, 0 insertions, 0 deletions