diff options
| author | fanquake <fanquake@gmail.com> | 2021-06-14 10:06:35 +0800 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2021-06-14 10:06:55 +0800 |
| commit | de5512e28df220990ad123b914167aadd6f50979 (patch) | |
| tree | 1bc97b59e41814d22a934470bce25ae39629b095 /build_msvc | |
| parent | ad2ab88ccc3af9ea6342361f3eccec06ed33e64a (diff) | |
| parent | 9edd713c184bd6b92ff7862d0df8f1a89062e9d3 (diff) | |
Merge bitcoin/bitcoin#22230: build: Fix MSVC linker /SubSystem option for bitcoin-qt.exe
9edd713c184bd6b92ff7862d0df8f1a89062e9d3 build: Fix MSVC linker /SubSystem option for bitcoin-qt.exe (Hennadii Stepanov)
Pull request description:
On master (6f3fbc062f97183f19a8551177371cc74a33351d), running `bitcoin-qt.exe`, which was built with MSVC, causes a terminal window open along with the GUI.
This PR fixes such behavior. See Microsoft [docs](https://docs.microsoft.com/en-us/cpp/build/reference/subsystem-specify-subsystem?view=msvc-160).
It is still possible to use the `-printtoconsole` option for debug builds.
ACKs for top commit:
sipsorcery:
tACK 9edd713c184bd6b92ff7862d0df8f1a89062e9d3.
Tree-SHA512: 02f2874b13e484f98344f6a7e3b01fa82a78a39865787c77bd674ead22a84a7f98a1849ccad26bd2b8c8603b3e29dcc1633b0ad731ce7d61be2d6b1f9584839c
Diffstat (limited to 'build_msvc')
| -rw-r--r-- | build_msvc/bitcoin-qt/bitcoin-qt.vcxproj | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/build_msvc/bitcoin-qt/bitcoin-qt.vcxproj b/build_msvc/bitcoin-qt/bitcoin-qt.vcxproj index 65ce1ee9da..a697c1dfb6 100644 --- a/build_msvc/bitcoin-qt/bitcoin-qt.vcxproj +++ b/build_msvc/bitcoin-qt/bitcoin-qt.vcxproj @@ -55,6 +55,7 @@ <AdditionalIncludeDirectories>$(QtIncludes);%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories> </ClCompile> <Link> + <SubSystem>Windows</SubSystem> <AdditionalDependencies>$(QtReleaseLibraries);%(AdditionalDependencies)</AdditionalDependencies> <AdditionalOptions>/ignore:4206 /LTCG:OFF</AdditionalOptions> </Link> |