diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2019-04-19 09:33:46 -0400 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2019-04-19 09:34:01 -0400 |
| commit | ae2c19f578b69b8fd7c05bfdd9015fd078734867 (patch) | |
| tree | 709e726cc69ed9efd167dee43a1387815d88aadf /build_msvc/test_bitcoin | |
| parent | d1c2ed8dd768fae8ba63b55f316a47b66e5b74f0 (diff) | |
| parent | 418d3230f86f77dde6e817f502baff8a54b707fa (diff) | |
Merge #15655: Resolve the checkpoints <-> validation circular dependency
418d3230f8 Resolve the checkpoints <-> validation CD. (251)
Pull request description:
This pull request attempts to resolve the `checkpoints -> validation -> checkpoints` circular dependency.
The circular dependency is resolved by moving the `CheckPoints::GetLastCheckpoint(const CCheckpointData& data)` function to `validation.cpp` where it used exclusively by the private function `ContextualCheckBlockHeader(const CBlockHeader& block, CValidationState& state, const CChainParams& params, const CBlockIndex* pindexPrev, int64_t nAdjustedTime)`.
ACKs for commit 418d32:
promag:
utACK 418d323, only `GetLastCheckpoint` usage is in `validation.cpp` and so makes sense to move it there.
practicalswift:
utACK 418d3230f86f77dde6e817f502baff8a54b707fa
MarcoFalke:
utACK 418d3230f86f77dde6e817f502baff8a54b707fa
sipa:
utACK 418d3230f86f77dde6e817f502baff8a54b707fa
Tree-SHA512: 03c3556bc192e65f5e3fa76fd545d4ee7d63d3fb06b132f7a1fa6131aa21ddd2e5b2d19e2222dfe524f422daaca30efde219bed188db8c74ff4b088876b5bc16
Diffstat (limited to 'build_msvc/test_bitcoin')
0 files changed, 0 insertions, 0 deletions