diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2020-10-01 09:43:00 +0200 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2020-10-01 09:43:11 +0200 |
| commit | 40aab35e9828427a800916ac15e3381332f4d0a6 (patch) | |
| tree | 1a740bddd7f2a7d7a20a918751d680af77961afa /build_msvc/test_bitcoin-qt | |
| parent | 3487e421a7fef4b28381efcf21a7e38483946cec (diff) | |
| parent | 825fcae484f31182041dfacbf820e818d759b130 (diff) | |
Merge #19253: Tests: tidy up address.py and segwit_addr.py
825fcae484f31182041dfacbf820e818d759b130 [tests] Replace bytes literals with hex literals (John Newbery)
64eca45100536579a3849631e59d4277bbc25be1 [tests] Fix pep8 style violations in address.py (John Newbery)
b230f8b3f3adcb1e2ae299094f9ae0a8bc7cc3d0 [tests] Correct docstring for address.py (John Newbery)
ea70e6a2ca0e183ef40cdb9b3b86f39e94366015 [tests] Tidy up imports in address.py (John Newbery)
7f639df0b8a15aaeccedab00b634925f568c2c9a [tests] Remove unused optional verify_checksum parameter (John Newbery)
011e784f74411bd5d5dbccfd3af39e0937fd8933 [tests] Rename segwit encode and decode functions (John Newbery)
e4557133f595f357df5e16ae4f2f19c579631396 [tests] Move bech32 unit tests to test framework (John Newbery)
Pull request description:
Lots of small fixes:
- moving unit tests to test_framework implementation files
- renaming functions to be clearer
- removing multiple imports
- removing unreadable byte literals from the code
- fixing pep8 violations
- correcting out-of-date docstring
ACKs for top commit:
jonatack:
re-ACK 825fcae484f31182041dfacbf820e818d759b130 per `git range-diff a0a422c 7edcdcd 825fcae` and verified `wallet_address_types.py` and `wallet_basic.py --descriptors` (the failure on one travis job) are green locally.
MarcoFalke:
ACK 825fcae484f31182041dfacbf820e818d759b130
fanquake:
ACK 825fcae484f31182041dfacbf820e818d759b130 - looks ok to me.
Tree-SHA512: aea509c27c1bcb94bef11205b6a79836c39c62249672815efc9822f411bc2e2336ceb3d72b3b861c3f4054a08e16edb28c6edd3aa5eff72eec1d60ea6ca82dc4
Diffstat (limited to 'build_msvc/test_bitcoin-qt')
0 files changed, 0 insertions, 0 deletions