diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2020-04-10 11:21:19 -0400 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2020-04-10 11:21:57 -0400 |
| commit | a840dab2a582747947db0ab92cfc829316966c96 (patch) | |
| tree | 65c056d933826b4386c154259375c69042c93b0c /build_msvc/bitcoin_config.h | |
| parent | 3347ca48816c7a0aab61573b23d7f8d902c1dac3 (diff) | |
| parent | fad691cafe083743a26f434488990f060ae4ac45 (diff) | |
Merge #18541: rpc: Make verifychain default values static, not depend on global args
fad691cafe083743a26f434488990f060ae4ac45 rpc: Make verifychain default values static, not depend on global args (MarcoFalke)
Pull request description:
This fixes several issues:
* The documentation is not compile-time static and depends on run-time arguments, making it impossible to host it on a static resource like a website or pdf. See also a similar change in the wallet rpc code: #18499
* The same call (relying on default values) will run different code on different machines, depending on the command line args that were used to start the server. This might lead to hard-to-debug-remote issues.
This is a small behaviour change, and I will add release notes.
ACKs for top commit:
theStack:
ACK https://github.com/bitcoin/bitcoin/pull/18541/commits/fad691cafe083743a26f434488990f060ae4ac45
promag:
Code review ACK fad691cafe083743a26f434488990f060ae4ac45.
Tree-SHA512: 1c7a253ff0ec13a973b10d3777b71c70954ded5805b65a3ab06317327014de4cd0601d71d30c6ce89a581722c150cb5567acc1bd3e0c789cb51bab6ef0dcfc4a
Diffstat (limited to 'build_msvc/bitcoin_config.h')
0 files changed, 0 insertions, 0 deletions