diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2020-09-30 08:58:15 +0200 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2020-09-30 09:01:23 +0200 |
| commit | 1769828684f16b53e5fbf65173f508b9ea1b4b9c (patch) | |
| tree | 83069672aace60ffeddbf683d28760171cb523e5 /build-aux | |
| parent | 36f5a58c021061a51f739962a0f045178bfacffa (diff) | |
| parent | 69cf5d4eeb73f7d685e915fc17af64634d88a4a2 (diff) | |
| download | bitcoin-1769828684f16b53e5fbf65173f508b9ea1b4b9c.tar.xz | |
Merge #19501: send* RPCs in the wallet returns the "fee reason"
69cf5d4eeb73f7d685e915fc17af64634d88a4a2 [test] Make sure send rpc returns fee reason (Sishir Giri)
d5863c0b3e20d56acf7246008b7832efde68ab21 [send] Make send RPCs return fee reason (Sishir Giri)
Pull request description:
Whenever a wallet funds a transaction, the fee reason is reported to the user only if the verbose is set to true. I added an extra parameter to `CreateTransaction` function in wallet.cpp. Then I implemented the fee reason return logic in `SendMoney` in rpcwallet.cpp, followed by verbose parameter in `sendtoaddress` and `sendmany` functions. I also added a fee reason test case in walletbasic.py.
link to the issue: https://github.com/MarcoFalke/bitcoin-core/issues/22#issue-616251578
ACKs for top commit:
instagibbs:
ACK https://github.com/bitcoin/bitcoin/pull/19501/commits/69cf5d4eeb73f7d685e915fc17af64634d88a4a2
meshcollider:
utACK 69cf5d4eeb73f7d685e915fc17af64634d88a4a2
Tree-SHA512: 2e3af32dcfbd5511ba95f8bc8edca7acfe709a8430ff03e43172e5d0af3dfa4b2f57906978e7f272d878043b9ed8c6004674cf47d7496b005d5f612e9a58aa0e
Diffstat (limited to 'build-aux')
0 files changed, 0 insertions, 0 deletions