diff options
| author | fanquake <fanquake@gmail.com> | 2021-12-03 19:01:24 +0800 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2021-12-03 19:09:58 +0800 |
| commit | 345c8180d7b743af9fb77bbdede1c4a2ee9440a4 (patch) | |
| tree | 0c41537adfeac7239637e86b63730fca1f52ed28 /build-aux/m4/bitcoin_find_bdb48.m4 | |
| parent | 8b1de78577a02300340cec37e26cd6418ef6e645 (diff) | |
| parent | fa3942fc4c66d7624bd3578d1e7f4a6a7721c11a (diff) | |
| download | bitcoin-345c8180d7b743af9fb77bbdede1c4a2ee9440a4.tar.xz | |
Merge bitcoin/bitcoin#23630: Remove GetSpendHeight
fa3942fc4c66d7624bd3578d1e7f4a6a7721c11a Remove GetSpendHeight (MarcoFalke)
Pull request description:
It is unclear what the goal of the helper is, as the caller already
knows the spend height before calling the helper.
Also, in case the coins view is corrupted, LookupBlockIndex will return
nullptr. Dereferencing a nullptr is UB.
Fix both issues by removing it. Also, add a sanity check, which aborts
if the coins view is corrupted.
ACKs for top commit:
laanwj:
Code review ACK fa3942fc4c66d7624bd3578d1e7f4a6a7721c11a
ryanofsky:
Code review ACK fa3942fc4c66d7624bd3578d1e7f4a6a7721c11a. I'm not aware of cases where coins GetBestBlock could be different from active chain tip, and asset seems sufficient to guarantee PR doesn't change behavior if that doesn't happen.
Tree-SHA512: 29f65d72e116ec5a4509e0947ceeaa5bb6b7dfd5d174d3c7945cb15fa266d590c4f8b48e6385de74ef7d7c84ebd2255de902ad9c87c24955348a91b12e5bffd5
Diffstat (limited to 'build-aux/m4/bitcoin_find_bdb48.m4')
0 files changed, 0 insertions, 0 deletions