diff options
author | MacroFake <falke.marco@gmail.com> | 2022-08-30 20:04:13 +0200 |
---|---|---|
committer | MacroFake <falke.marco@gmail.com> | 2022-08-30 20:04:17 +0200 |
commit | 52dcb1d2a319a34202fc1b21c3a137d45cb010b4 (patch) | |
tree | b45eb133f4950dcd231558825bf7141b874212fc /Makefile.am | |
parent | e9035f867a36a430998e3811385958229ac79cf5 (diff) | |
parent | f345dc3960c2cf4d69ebbcc011e4e836205f0361 (diff) | |
download | bitcoin-52dcb1d2a319a34202fc1b21c3a137d45cb010b4.tar.xz |
Merge bitcoin/bitcoin#25733: tidy: enable bugprone-use-after-move
f345dc3960c2cf4d69ebbcc011e4e836205f0361 tidy: enable bugprone-use-after-move (fanquake)
94f2235f858bc4fdaf0ab0882599f6a228401cf5 test: work around bugprone-use-after-move warnings in util tests (fanquake)
Pull request description:
Would have caught #25640.
Currently `// NOLINT`s around:
```bash
test/util_tests.cpp:2513:34: error: 't2' used after it was moved [bugprone-use-after-move,-warnings-as-errors]
BOOST_CHECK(v2[0].origin == &t2);
^
test/util_tests.cpp:2511:15: note: move occurred here
auto v2 = Vector(std::move(t2));
^
test/util_tests.cpp:2519:34: error: 't2' used after it was moved [bugprone-use-after-move,-warnings-as-errors]
BOOST_CHECK(v3[1].origin == &t2);
^
test/util_tests.cpp:2516:15: note: move occurred here
auto v3 = Vector(t1, std::move(t2));
^
test/util_tests.cpp:2527:34: error: 't3' used after it was moved [bugprone-use-after-move,-warnings-as-errors]
BOOST_CHECK(v4[2].origin == &t3);
^
test/util_tests.cpp:2523:15: note: move occurred here
auto v4 = Vector(std::move(v3[0]), v3[1], std::move(t3));
```
See: https://releases.llvm.org/14.0.0/tools/clang/tools/extra/docs/clang-tidy/checks/bugprone-use-after-move.html
ACKs for top commit:
ryanofsky:
Code review ACK f345dc3960c2cf4d69ebbcc011e4e836205f0361. Only change since last review is switching to NOLINT directives
Tree-SHA512: afadecbaf1069653f4be5d6e66a5800ffd975c0b1a960057abc6367b616c181cd518897a874a8f3fd5e5e1f45fcc165f7a9a3171136cd4deee641214c4b765b8
Diffstat (limited to 'Makefile.am')
0 files changed, 0 insertions, 0 deletions