diff options
| author | Wladimir J. van der Laan <laanwj@protonmail.com> | 2020-04-22 13:59:11 +0200 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@protonmail.com> | 2020-04-22 14:17:01 +0200 |
| commit | 19032c750cb48338bd178fd785ed345e87235e2e (patch) | |
| tree | 12ca76838ddeff66e87d8aa95e22d91b977f81af /COPYING | |
| parent | c90a9e6fffa73707b6fcd4c39c39b2fc5aaf8398 (diff) | |
| parent | ccccd5190898ece3ac17aa3178f320d091f221df (diff) | |
| download | bitcoin-19032c750cb48338bd178fd785ed345e87235e2e.tar.xz | |
Merge #18612: script: Remove undocumented and unused operator+
ccccd5190898ece3ac17aa3178f320d091f221df script: Remove undocumented and unused operator+ (MarcoFalke)
Pull request description:
This operator has no documented use case and is also unused outside of test code. The test code and all other (imaginary) code that might use this operator is written more clear and concise by the existing CScript push operators for opcodes and data.
Removing the operator is also going to protect against accidentally reintroducing bugs like this https://github.com/bitcoin/bitcoin/commit/6ff5f718b6a67797b2b3bab8905d607ad216ee21#diff-8458adcedc17d046942185cb709ff5c3L1135 (last time it was used).
ACKs for top commit:
laanwj:
ACK ccccd5190898ece3ac17aa3178f320d091f221df
Tree-SHA512: 43898ac77e4d9643d9f8ac6f8f65497a4f0bbb1fb5dcaecc839c3719aa36181ba77befb213e59a9f33a20a29e0173a0e9c4763b1930940b32c3d1598b3e39af9
Diffstat (limited to 'COPYING')
0 files changed, 0 insertions, 0 deletions