aboutsummaryrefslogtreecommitdiff
path: root/CONTRIBUTING.md
diff options
context:
space:
mode:
authorfanquake <fanquake@gmail.com>2020-01-06 15:18:10 +0800
committerfanquake <fanquake@gmail.com>2020-01-06 15:46:26 +0800
commite8e79958a7b2a0bf1b02adcce9f4d811eac37dfc (patch)
tree5ea0ec35eb2eda01a010ba22a55c1ddf09300682 /CONTRIBUTING.md
parentb949ac9697a6cfe087f60a16c063ab9c5bf1e81f (diff)
parent71af793512100ee7d508c3fb815af47925fe80ba (diff)
Merge #17857: scripts: fix symbol-check & security-check argument passing
71af793512100ee7d508c3fb815af47925fe80ba scripts: fix check-symbols & check-security argument passing (fanquake) Pull request description: The first argument in `bin_PROGRAMS` (`bitcoind`) was being silently consumed and never passed into the [`security-check.py`](https://github.com/bitcoin/bitcoin/blob/master/contrib/devtools/security-check.py) or [`symbol-check.py`](https://github.com/bitcoin/bitcoin/blob/master/contrib/devtools/symbol-check.py) scripts. This seems to have been the case since the scripts were added to the makefile in https://github.com/bitcoin/bitcoin/commit/f3d3eaf78eb51238d799d8f20a585550d1567719. Example of the behavior: ```python # touch a, touch b, touch c # python3 args.py < a b c import sys if __name__ == '__main__': print(sys.argv) # ['args.py', 'b', 'c'] # if you add some lines to "a", # you'll see them here.. for line in sys.stdin: print(line) ``` ACKs for top commit: laanwj: ACK 71af793512100ee7d508c3fb815af47925fe80ba Tree-SHA512: 9d0b975a11f66fd87a76654d210808000a629c9cce4c760f71e8a2bcb4e99b9109419f2306db67cf9b12c28e40b96ae722b7c9b4569b2b8bacd469fb99db30c3
Diffstat (limited to 'CONTRIBUTING.md')
0 files changed, 0 insertions, 0 deletions