diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2018-12-22 21:40:02 +0100 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2018-12-22 21:40:07 +0100 |
| commit | e2dfeb0146da046ad34655b17941e54e4b3d7769 (patch) | |
| tree | fdbb9b1e143448138d2447854b41b59be0f69554 /CONTRIBUTING.md | |
| parent | 18857b4c4034af54e7ad3cbd78ff6f87f4f22567 (diff) | |
| parent | 66e15e8f9759b827732865e5686c0203ce7dc1d4 (diff) | |
Merge #13930: doc: Better explain GetAncestor check for m_failed_blocks in AcceptBlockHeader
66e15e8f97 Explain GetAncestor check for m_failed_blocks in AcceptBlockHeader (Sjors Provoost)
Pull request description:
Salvaged (but slightly modified) from #12138, the comment there was really helpful to wrap my head around that part of the code.
In addition, a naive reader like yours truly will first think `IsValid(BLOCK_VALID_SCRIPTS)` means the previous block was invalid. But IIUC that's not what it means. Instead, it means the block hasn't been checked for validity at the `BLOCK_VALID_SCRIPTS` level yet. So in that case the existing text "previous block index isn't valid" is wrong.
Tree-SHA512: 442a319a83290d94697fdf51376463b70454e0f3909d4a45594ddc2e7c26cd19dc703808385a25e26d6d2dddab0aa35ca41722f2e65ee6fe57bbaf62652d3ec8
Diffstat (limited to 'CONTRIBUTING.md')
0 files changed, 0 insertions, 0 deletions