diff options
author | Vasil Dimov <vd@FreeBSD.org> | 2018-03-14 06:04:42 +0100 |
---|---|---|
committer | Vasil Dimov <vd@FreeBSD.org> | 2018-03-14 10:11:01 +0100 |
commit | 2b3ea39de40bc7754cab558245e4ddac1b261750 (patch) | |
tree | b462c94c233b97a5c024609d48f8b1bc513a4729 /CONTRIBUTING.md | |
parent | 6acd8700bc0ee1d10207a362c1e07372ba274041 (diff) | |
download | bitcoin-2b3ea39de40bc7754cab558245e4ddac1b261750.tar.xz |
Polish interfaces around PeerLogicValidation
* Make PeerLogicValidation final to prevent deriving from it [1]
* Prevent deletions of NetEventsInterface and CValidationInterface
objects via a base class pointer
[1] silences the following compiler warning (from Clang 7.0.0):
/usr/include/c++/v1/memory:2285:5: error: delete called on non-final 'PeerLogicValidation' that has
virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]
delete __ptr;
^
/usr/include/c++/v1/memory:2598:7: note: in instantiation of member function
'std::__1::default_delete<PeerLogicValidation>::operator()' requested here
__ptr_.second()(__tmp);
^
init.cpp:201:15: note: in instantiation of member function 'std::__1::unique_ptr<PeerLogicValidation,
std::__1::default_delete<PeerLogicValidation> >::reset' requested here
peerLogic.reset();
^
Diffstat (limited to 'CONTRIBUTING.md')
0 files changed, 0 insertions, 0 deletions