diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2020-10-16 14:08:24 +0200 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2020-10-16 14:08:35 +0200 |
| commit | 9e8d2bd076d78ba59abceb80106f44fe26246b14 (patch) | |
| tree | 4da4a4cb5b8643986ddf8c8d6c1b689d6e5e1cfb /CONTRIBUTING.md | |
| parent | cb21d864c52b7858000ff6c8727240f1721132a9 (diff) | |
| parent | 0d9d2a1f7c26dc9c7b233ea8c3182fe1f8936bca (diff) | |
Merge bitcoin-core/gui#97: Relax GUI freezes during IBD (when using wallets)
0d9d2a1f7c26dc9c7b233ea8c3182fe1f8936bca Only update the updateSmartFeeLabel once in sync (Jonas Schnelli)
Pull request description:
Calling `updateSmartFeeLabel` and therefore `estimateSmartFee` is pointless during IBD.
GUI freezes appear because `estimateSmartFee` competes with `processBlock` for the `m_cs_fee_estimator` lock leading to multiple seconds of blocking the GUI thread in `updateSmartFeeLabel`.
ACKs for top commit:
ryanofsky:
Code review ACK 0d9d2a1f7c26dc9c7b233ea8c3182fe1f8936bca. Clever fix. Didn't test but I remember I could reproduce the startup issue easily before by putting a sleep in estimateSmartFee.
promag:
Code review ACK 0d9d2a1f7c26dc9c7b233ea8c3182fe1f8936bca.
hebasto:
ACK 0d9d2a1f7c26dc9c7b233ea8c3182fe1f8936bca, tested on Linux Mint 20 (x86_64) with `QT_FATAL_WARNINGS=1` and `-debug=qt`.
Tree-SHA512: 85ec2266f06ddd7b523e24d2a462f10ed965d5b4d479005263056f81b7fe49996e1568dafb84658af406e9202ed3bfa846d59c10bb951e0f97cee230e30fafd5
Diffstat (limited to 'CONTRIBUTING.md')
0 files changed, 0 insertions, 0 deletions