diff options
author | Russell Yanofsky <russ@yanofsky.org> | 2017-03-09 17:56:23 -0500 |
---|---|---|
committer | Russell Yanofsky <russ@yanofsky.org> | 2017-05-23 12:39:50 -0500 |
commit | 5749a48821f6a83d17b4f4626d09d6abdada5135 (patch) | |
tree | 4ad44d14509e2d4198b9f021ce0059551480a976 /CONTRIBUTING.md | |
parent | 7e96ecf075e8633f83ed1e05052402fb6b4d6186 (diff) |
Add Qt tests for wallet spends & bumpfee
A few code changes were needed to accompany the test:
* Adding setObjectName() calls for a few Qt controls to make them easily
accessible from the test.
* Calling contextMenu->popup() instead of contextMenu->exec() to open
the transaction list context menu without blocking the test thread.
* Opening the context menu at the contextualMenu event point rather than
the cursor position (this change was not strictly needed to make the test
work, but is more correct).
* Updating the bumped transaction row with showTransaction=true instead of
false. This is needed to prevent the bumped tx from being hidden, so the last
part of the test which attempts to bump the bumped tx can work. (Technically
this change is a more general bugfix not limited to the testing environment,
but the bug doesn't happen outside of the testing environment because in the
full Qt client, a queued NotifyTransactionChanged notification causes the row
to be updated twice, first with showTransaction=false, then immediately after
with showTransaction=true.)
Diffstat (limited to 'CONTRIBUTING.md')
0 files changed, 0 insertions, 0 deletions