diff options
| author | laanwj <126646+laanwj@users.noreply.github.com> | 2022-06-07 21:17:06 +0200 |
|---|---|---|
| committer | laanwj <126646+laanwj@users.noreply.github.com> | 2022-06-07 21:17:45 +0200 |
| commit | 9dae9f5f1e2bf29f58d3f49b0c612063d883b8b3 (patch) | |
| tree | edbfa65edf1ece93df349ad9196dd948f672ea35 | |
| parent | 79cabe3a5b03e84ae5cb78046538777fd848267b (diff) | |
| parent | 433b52569417674f84c2b1d449037701814420c4 (diff) | |
Merge bitcoin/bitcoin#25292: Add LogPrintLevel to lint-format-strings, drop LogPrint-vs-LogPrintf section in dev notes
433b52569417674f84c2b1d449037701814420c4 Add LogPrintLevel to lint-format-strings, drop LogPrint-vs-LogPrintf section in dev notes (Jon Atack)
Pull request description:
added by #7003 in 2015, as that potential issue would now be caught by the `test/lint/lint-format-strings.py` script run by the CI.
ACKs for top commit:
MarcoFalke:
cr ACK 433b52569417674f84c2b1d449037701814420c4
w0xlt:
ACK https://github.com/bitcoin/bitcoin/pull/25292/commits/433b52569417674f84c2b1d449037701814420c4
Tree-SHA512: 91a2ac76689ed4f1f638e07c16d2ec8952fb013cc8bb896780fbd9333abd084281ce99afdc9de715d07a9abb4dce5dd67edf5e347aff466c6ef339ccc4158679
| -rw-r--r-- | doc/developer-notes.md | 5 | ||||
| -rwxr-xr-x | test/lint/lint-format-strings.py | 1 |
2 files changed, 1 insertions, 5 deletions
diff --git a/doc/developer-notes.md b/doc/developer-notes.md index 4843e61ee8..bd385efdfd 100644 --- a/doc/developer-notes.md +++ b/doc/developer-notes.md @@ -831,11 +831,6 @@ int GetInt(Tabs tab) Strings and formatting ------------------------ -- Be careful of `LogPrint` versus `LogPrintf`. `LogPrint` takes a `category` argument, `LogPrintf` does not. - - - *Rationale*: Confusion of these can result in runtime exceptions due to - formatting mismatch, and it is easy to get wrong because of subtly similar naming. - - Use `std::string`, avoid C string manipulation functions. - *Rationale*: C++ string handling is marginally safer, less scope for diff --git a/test/lint/lint-format-strings.py b/test/lint/lint-format-strings.py index 28e7b1e4ff..412cf86791 100755 --- a/test/lint/lint-format-strings.py +++ b/test/lint/lint-format-strings.py @@ -22,6 +22,7 @@ FUNCTION_NAMES_AND_NUMBER_OF_LEADING_ARGUMENTS = [ 'LogConnectFailure,1', 'LogPrint,1', 'LogPrintf,0', + 'LogPrintLevel,2', 'printf,0', 'snprintf,2', 'sprintf,1', |