diff options
| author | fanquake <fanquake@gmail.com> | 2021-04-13 21:16:59 +0800 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2021-04-13 21:17:20 +0800 |
| commit | 88331aa8a7627ca82e5ec4f92eaa2d206e76b7c5 (patch) | |
| tree | 0c03cd38d9c4bbae02ea83c5363c6cb6d85ce9bc | |
| parent | 3aa4935db722c77e99f2ca57dea3692215c68963 (diff) | |
| parent | 003929c0d55532038d5bf6fc0ff4a20628710fae (diff) | |
Merge #21633: refactor: add [[noreturn]] attribute where applicable
003929c0d55532038d5bf6fc0ff4a20628710fae refactor: add [[noreturn]] attribute where applicable (fanquake)
Pull request description:
Similar to #10843. We could build with `-Wmissing-noreturn`, however that would also mean modifying something like `--suppress-external-warnings` to suppress warnings for leveldb, which I don't think we want to do. In any case, the functions where this is applicable are only added/removed very rarely.
ACKs for top commit:
vasild:
ACK 003929c0d55532038d5bf6fc0ff4a20628710fae
Tree-SHA512: 33dfa6547d6b84f38a941f24d4c2effe8fde7b93dbc0b27a9309716420e4a879fdbe689d789fa5439d65f5f78292f89fd9dc1b61c97acf69316dfed954086705
| -rw-r--r-- | src/test/util_tests.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/test/util_tests.cpp b/src/test/util_tests.cpp index 5ac09b05db..a1ac9ead69 100644 --- a/src/test/util_tests.cpp +++ b/src/test/util_tests.cpp @@ -1766,7 +1766,7 @@ static constexpr char LockCommand = 'L'; static constexpr char UnlockCommand = 'U'; static constexpr char ExitCommand = 'X'; -static void TestOtherProcess(fs::path dirname, std::string lockname, int fd) +[[noreturn]] static void TestOtherProcess(fs::path dirname, std::string lockname, int fd) { char ch; while (true) { |