diff options
| author | fanquake <fanquake@gmail.com> | 2022-01-31 12:58:40 +0800 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2022-01-31 13:35:57 +0800 |
| commit | 32ee7675fa695a86db8ebbf5bb454169bb1fcea5 (patch) | |
| tree | c508680ccefe52d10aba6d99219361e7b8e78a87 | |
| parent | 5b4b8f76f3ae11064d4aa3ac157558e364751fd2 (diff) | |
| parent | b3ccf26df47c70e7559625a0e65205648f64efb7 (diff) | |
Merge bitcoin/bitcoin#24111: build: force CRCCheck in Windows installer
b3ccf26df47c70e7559625a0e65205648f64efb7 build: force CRCCheck in Windows installer (fanquake)
Pull request description:
Otherwise a user can pass `/NCRC` on the command line and bypass the
CRC check, meaning they could use a corrupted installer. I can't think of
a reason why we'd want to allow the use of corrupted installers.
[NSIS docs](https://nsis.sourceforge.io/Docs/Chapter4.html#acrccheck):
> Specifies whether or not the installer will perform a CRC on itself before allowing an install. Note that if the user uses /NCRC on the command line when executing the installer, and you didn't specify 'force', the CRC will not occur, and the user will be allowed to install a (potentially) corrupted installer.
ACKs for top commit:
hebasto:
ACK b3ccf26df47c70e7559625a0e65205648f64efb7, I have reviewed the code and it looks OK, I agree it can be merged.
prusnak:
utACK b3ccf26df47c70e7559625a0e65205648f64efb7
Tree-SHA512: 6b3c151bfd896dbf1a4af26114aec1721e4d4e6dad89eef796cd754c988b1bb03fd9a3f9889be3c754ff5b1cd7bf5bbfc126876c76038205c17807daff029319
| -rw-r--r-- | share/setup.nsi.in | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/share/setup.nsi.in b/share/setup.nsi.in index 85ae7c57af..c7b149345c 100644 --- a/share/setup.nsi.in +++ b/share/setup.nsi.in @@ -53,7 +53,7 @@ Var StartMenuGroup # Installer attributes InstallDir $PROGRAMFILES64\Bitcoin -CRCCheck on +CRCCheck force XPStyle on BrandingText " " ShowInstDetails show |