diff options
author | fanquake <fanquake@gmail.com> | 2021-12-28 20:31:07 +0800 |
---|---|---|
committer | fanquake <fanquake@gmail.com> | 2021-12-28 20:31:46 +0800 |
commit | 1292334bf5c0ba768c102d24cd28d547fb501bdc (patch) | |
tree | 8fd4ffa38c23d7ff21d71bb9b993cef0ec6f172e | |
parent | 5d2344885bb50cada57bbec79f473db79cfab96c (diff) | |
parent | fa50d8b66e74792eb46515853e4aa8a99f25561b (diff) | |
download | bitcoin-1292334bf5c0ba768c102d24cd28d547fb501bdc.tar.xz |
Merge bitcoin/bitcoin#23878: doc: Remove TODO comment in tx_verify
fa50d8b66e74792eb46515853e4aa8a99f25561b doc: Remove TODO comment in tx_verify (MarcoFalke)
Pull request description:
The comment has no clear motivation, so it seems better to remove it and fix it when there is a reason.
An alternative (if a fix isn't possible when there is a clear motivation) would be to create an issue thread for easier discussion.
ACKs for top commit:
fanquake:
ACK fa50d8b66e74792eb46515853e4aa8a99f25561b
Tree-SHA512: e9c25bab46a73b7c2db288c62ed9838a5e794b3b72db494173f4502da60b58dec4383064964c0842932cd30e4251fc01ad0c28681e2ef6cb442482eea2bad595
-rw-r--r-- | src/consensus/tx_verify.cpp | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/src/consensus/tx_verify.cpp b/src/consensus/tx_verify.cpp index a07adae536..3cd0d18e9e 100644 --- a/src/consensus/tx_verify.cpp +++ b/src/consensus/tx_verify.cpp @@ -4,15 +4,13 @@ #include <consensus/tx_verify.h> +#include <chain.h> +#include <coins.h> #include <consensus/amount.h> #include <consensus/consensus.h> +#include <consensus/validation.h> #include <primitives/transaction.h> #include <script/interpreter.h> -#include <consensus/validation.h> - -// TODO remove the following dependencies -#include <chain.h> -#include <coins.h> #include <util/moneystr.h> bool IsFinalTx(const CTransaction &tx, int nBlockHeight, int64_t nBlockTime) |