diff options
| author | fanquake <fanquake@gmail.com> | 2021-03-22 11:30:25 +0800 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2021-03-22 11:43:35 +0800 |
| commit | 80cb51cc6b417fb7b23fc8b299f0605e7f82c62d (patch) | |
| tree | af169fc9b2bf90e2859f7989227d584db355f7ef | |
| parent | d2a78ee9288e4d3bace9125bcfae6b7747f85982 (diff) | |
| parent | 7e3444805ed747db819d7bf630feafc31783e5de (diff) | |
| download | bitcoin-80cb51cc6b417fb7b23fc8b299f0605e7f82c62d.tar.xz | |
Merge #21491: test: remove duplicate assertions in util_tests
7e3444805ed747db819d7bf630feafc31783e5de test: remove duplicate assertions in util_tests (Jon Atack)
Pull request description:
as noticed by Kiminuo in https://github.com/bitcoin/bitcoin/pull/21488#discussion_r598247676
ACKs for top commit:
practicalswift:
cr ACK 7e3444805ed747db819d7bf630feafc31783e5de: patch looks correct
vasild:
ACK 7e3444805ed747db819d7bf630feafc31783e5de
Tree-SHA512: ad3d5983ad3a665155d766843dfda7178ced47e82154838331e428ed0828a467c1cf4bf99270aaf191e94156d485fafd0a7d5bc68248c4c1304a00ca5a2a9d2e
| -rw-r--r-- | src/test/util_tests.cpp | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/src/test/util_tests.cpp b/src/test/util_tests.cpp index 470a8a3a44..2e7685bf9e 100644 --- a/src/test/util_tests.cpp +++ b/src/test/util_tests.cpp @@ -1450,7 +1450,6 @@ BOOST_AUTO_TEST_CASE(test_ParseInt32) BOOST_CHECK(!ParseInt32("1a", &n)); BOOST_CHECK(!ParseInt32("aap", &n)); BOOST_CHECK(!ParseInt32("0x1", &n)); // no hex - BOOST_CHECK(!ParseInt32("0x1", &n)); // no hex BOOST_CHECK(!ParseInt32(STRING_WITH_EMBEDDED_NULL_CHAR, &n)); // Overflow and underflow BOOST_CHECK(!ParseInt32("-2147483649", nullptr)); @@ -1513,7 +1512,6 @@ BOOST_AUTO_TEST_CASE(test_ParseUInt8) BOOST_CHECK(!ParseUInt8("1a", &n)); BOOST_CHECK(!ParseUInt8("aap", &n)); BOOST_CHECK(!ParseUInt8("0x1", &n)); // no hex - BOOST_CHECK(!ParseUInt8("0x1", &n)); // no hex BOOST_CHECK(!ParseUInt8(STRING_WITH_EMBEDDED_NULL_CHAR, &n)); // Overflow and underflow BOOST_CHECK(!ParseUInt8("-255", &n)); @@ -1549,7 +1547,6 @@ BOOST_AUTO_TEST_CASE(test_ParseUInt16) BOOST_CHECK(!ParseUInt16("1a", &n)); BOOST_CHECK(!ParseUInt16("aap", &n)); BOOST_CHECK(!ParseUInt16("0x1", &n)); // no hex - BOOST_CHECK(!ParseUInt16("0x1", &n)); // no hex BOOST_CHECK(!ParseUInt16(STRING_WITH_EMBEDDED_NULL_CHAR, &n)); // Overflow and underflow BOOST_CHECK(!ParseUInt16("-65535", &n)); @@ -1587,7 +1584,6 @@ BOOST_AUTO_TEST_CASE(test_ParseUInt32) BOOST_CHECK(!ParseUInt32("1a", &n)); BOOST_CHECK(!ParseUInt32("aap", &n)); BOOST_CHECK(!ParseUInt32("0x1", &n)); // no hex - BOOST_CHECK(!ParseUInt32("0x1", &n)); // no hex BOOST_CHECK(!ParseUInt32(STRING_WITH_EMBEDDED_NULL_CHAR, &n)); // Overflow and underflow BOOST_CHECK(!ParseUInt32("-2147483648", &n)); |