diff options
| author | John Newbery <john@johnnewbery.com> | 2021-11-03 12:06:40 +0000 |
|---|---|---|
| committer | John Newbery <john@johnnewbery.com> | 2021-11-03 14:28:04 +0000 |
| commit | 36167faea92c97ddea7403280a5074073c8e5f90 (patch) | |
| tree | 21879ffc86537282ca1d41abe551ec22b1bd1d4d | |
| parent | 4c24142b1ec121623f81ba644d77341bc1bd88dd (diff) | |
[logging/documentation] Remove reference to AcceptToMemoryPool from error string
User-facing error messages should not leak internal implementation
details like function names. Update the MEMPOOL_REJECTED error string
from "Transaction rejected by AcceptToMemoryPool" to the more generic
"Transaction rejected by mempool". Also update the MEMPOOL_ERROR error
message from "AcceptToMemoryPool failed" to the more precise "Mempool
internal error" since this error indicates and internal (e.g.
logic/hardware/etc) failure, and not a transaction rejection.
| -rw-r--r-- | src/util/error.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/util/error.cpp b/src/util/error.cpp index 48c81693f3..d019ba018d 100644 --- a/src/util/error.cpp +++ b/src/util/error.cpp @@ -20,9 +20,9 @@ bilingual_str TransactionErrorString(const TransactionError err) case TransactionError::P2P_DISABLED: return Untranslated("Peer-to-peer functionality missing or disabled"); case TransactionError::MEMPOOL_REJECTED: - return Untranslated("Transaction rejected by AcceptToMemoryPool"); + return Untranslated("Transaction rejected by mempool"); case TransactionError::MEMPOOL_ERROR: - return Untranslated("AcceptToMemoryPool failed"); + return Untranslated("Mempool internal error"); case TransactionError::INVALID_PSBT: return Untranslated("PSBT is not well-formed"); case TransactionError::PSBT_MISMATCH: |