diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2021-11-15 17:27:15 +0100 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2021-11-15 17:27:17 +0100 |
| commit | 15d109802ab93b0af9647858c9d8adcd8a2db84a (patch) | |
| tree | 43dd4b67ac5317f8896ba1628b01f8625bb3a7de | |
| parent | fa2303989bed629c1d6911034370db66c5485ce0 (diff) | |
| parent | 23c3dcb4e74b21c7a1f1bb334cb5547a6bf128f1 (diff) | |
| download | bitcoin-15d109802ab93b0af9647858c9d8adcd8a2db84a.tar.xz | |
Merge bitcoin/bitcoin#23513: ci: Drop --failfast in functional tests on native Windows CI task
23c3dcb4e74b21c7a1f1bb334cb5547a6bf128f1 ci: Drop --failfast in functional tests on native Windows CI task (Hennadii Stepanov)
Pull request description:
As it was [discussed](https://github.com/bitcoin/bitcoin/pull/22980#issuecomment-964073830) in bitcoin/bitcoin#22980:
> seeing _all_ of the failed tests can give us a useful hint for debugging (was thinking about that while reviewing and testing bitcoin/bitcoin#23300).
There is a [concern](https://github.com/bitcoin/bitcoin/pull/22980#issuecomment-964085922) about such approach:
> If there is a CI failure, it will be good to know the result as early as possible after opening the pull request.
But, [OTOH](https://github.com/bitcoin/bitcoin/pull/22980#issuecomment-964095026):
> the average amount of saved time for such an approach [using `--failfast`] is less significant than it could appear.
ACKs for top commit:
MarcoFalke:
cr ACK 23c3dcb4e74b21c7a1f1bb334cb5547a6bf128f1 seems fine to give this a try
Tree-SHA512: d28f5712b4edfdbcef48b0633017da9172cef1835bcea51eaeeabf15c133f6bb6888227afc130279c3899365a4fd0f200fb9b0c4cb1ff80f21cbc766b8907764
| -rw-r--r-- | .cirrus.yml | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/.cirrus.yml b/.cirrus.yml index f7962e951c..ed65510293 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -164,7 +164,7 @@ task: - netsh int ipv4 set dynamicport tcp start=1025 num=64511 - netsh int ipv6 set dynamicport tcp start=1025 num=64511 # Exclude feature_dbcrash for now due to timeout - - python test\functional\test_runner.py --nocleanup --ci --quiet --combinedlogslen=4000 --jobs=4 --timeout-factor=8 --failfast --extended --exclude feature_dbcrash + - python test\functional\test_runner.py --nocleanup --ci --quiet --combinedlogslen=4000 --jobs=4 --timeout-factor=8 --extended --exclude feature_dbcrash task: name: 'ARM [unit tests, no functional tests] [bullseye]' |