diff options
author | John Newbery <john@johnnewbery.com> | 2021-08-18 09:45:54 +0100 |
---|---|---|
committer | Amiti Uttarwar <amiti@uttarwar.org> | 2021-08-26 11:56:13 -0700 |
commit | 85b15ddc8ff499fe21d8ab35ece3994f8878b3de (patch) | |
tree | f2d5df057f4aac2c8aa8580335f6876e09fd6130 | |
parent | af9638a0fbb79bec743f4d2275b89e9573cfdc0a (diff) |
[refactor] [addrman] Update constant comments
Co-authored-by: Amiti Uttarwar <amiti@uttarwar.org>
-rw-r--r-- | src/addrman.cpp | 30 | ||||
-rw-r--r-- | src/addrman.h | 6 |
2 files changed, 13 insertions, 23 deletions
diff --git a/src/addrman.cpp b/src/addrman.cpp index ec1c6c975f..48e79c64ed 100644 --- a/src/addrman.cpp +++ b/src/addrman.cpp @@ -15,37 +15,27 @@ #include <unordered_map> #include <unordered_set> -//! over how many buckets entries with tried addresses from a single group (/16 for IPv4) are spread +/** Over how many buckets entries with tried addresses from a single group (/16 for IPv4) are spread */ static constexpr uint32_t ADDRMAN_TRIED_BUCKETS_PER_GROUP{8}; - -//! over how many buckets entries with new addresses originating from a single group are spread +/** Over how many buckets entries with new addresses originating from a single group are spread */ static constexpr uint32_t ADDRMAN_NEW_BUCKETS_PER_SOURCE_GROUP{64}; - -//! in how many buckets for entries with new addresses a single address may occur +/** Maximum number of times an address can be added to the new table */ static constexpr int32_t ADDRMAN_NEW_BUCKETS_PER_ADDRESS{8}; - -//! how old addresses can maximally be +/** How old addresses can maximally be */ static constexpr int64_t ADDRMAN_HORIZON_DAYS{30}; - -//! after how many failed attempts we give up on a new node +/** After how many failed attempts we give up on a new node */ static constexpr int32_t ADDRMAN_RETRIES{3}; - -//! how many successive failures are allowed ... +/** How many successive failures are allowed ... */ static constexpr int32_t ADDRMAN_MAX_FAILURES{10}; - -//! ... in at least this many days +/** ... in at least this many days */ static constexpr int64_t ADDRMAN_MIN_FAIL_DAYS{7}; - -//! how recent a successful connection should be before we allow an address to be evicted from tried +/** How recent a successful connection should be before we allow an address to be evicted from tried */ static constexpr int64_t ADDRMAN_REPLACEMENT_HOURS{4}; - -//! the maximum number of tried addr collisions to store +/** The maximum number of tried addr collisions to store */ static constexpr size_t ADDRMAN_SET_TRIED_COLLISION_SIZE{10}; - -//! the maximum time we'll spend trying to resolve a tried table collision, in seconds +/** The maximum time we'll spend trying to resolve a tried table collision, in seconds */ static constexpr int64_t ADDRMAN_TEST_WINDOW{40*60}; // 40 minutes - int CAddrInfo::GetTriedBucket(const uint256& nKey, const std::vector<bool> &asmap) const { uint64_t hash1 = (CHashWriter(SER_GETHASH, 0) << nKey << GetKey()).GetCheapHash(); diff --git a/src/addrman.h b/src/addrman.h index b6d115e741..2548b891ba 100644 --- a/src/addrman.h +++ b/src/addrman.h @@ -131,15 +131,15 @@ public: * configuration option will introduce (expensive) consistency checks for the entire data structure. */ -//! total number of buckets for tried addresses +/** Total number of buckets for tried addresses */ static constexpr int32_t ADDRMAN_TRIED_BUCKET_COUNT_LOG2{8}; static constexpr int ADDRMAN_TRIED_BUCKET_COUNT{1 << ADDRMAN_TRIED_BUCKET_COUNT_LOG2}; -//! total number of buckets for new addresses +/** Total number of buckets for new addresses */ static constexpr int32_t ADDRMAN_NEW_BUCKET_COUNT_LOG2{10}; static constexpr int ADDRMAN_NEW_BUCKET_COUNT{1 << ADDRMAN_NEW_BUCKET_COUNT_LOG2}; -//! maximum allowed number of entries in buckets for new and tried addresses +/** Maximum allowed number of entries in buckets for new and tried addresses */ static constexpr int32_t ADDRMAN_BUCKET_SIZE_LOG2{6}; static constexpr int ADDRMAN_BUCKET_SIZE{1 << ADDRMAN_BUCKET_SIZE_LOG2}; |