aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMarcoFalke <falke.marco@gmail.com>2019-07-25 18:15:41 -0400
committerMarcoFalke <falke.marco@gmail.com>2019-08-15 08:05:14 -0400
commitfa3c6575cac5e3841797980fe60b8368ae579dba (patch)
treefe58ce2671756a98918e237fcde8dd3fe7c74b98
parentfa25668e1c8982548f1c6f94780709c625811469 (diff)
lint: Add false positive to python dead code linter
-rwxr-xr-x.travis/lint_04_install.sh6
-rw-r--r--test/lint/lint-python-dead-code-whitelist45
-rwxr-xr-xtest/lint/lint-python-dead-code.sh4
3 files changed, 50 insertions, 5 deletions
diff --git a/.travis/lint_04_install.sh b/.travis/lint_04_install.sh
index 62174620f2..20bff368a5 100755
--- a/.travis/lint_04_install.sh
+++ b/.travis/lint_04_install.sh
@@ -6,9 +6,9 @@
export LC_ALL=C
-travis_retry pip install codespell==1.15.0
-travis_retry pip install flake8==3.5.0
-travis_retry pip install vulture==0.29
+travis_retry pip3 install codespell==1.15.0
+travis_retry pip3 install flake8==3.5.0
+travis_retry pip3 install vulture==0.29
SHELLCHECK_VERSION=v0.6.0
curl -s "https://storage.googleapis.com/shellcheck/shellcheck-${SHELLCHECK_VERSION}.linux.x86_64.tar.xz" | tar --xz -xf - --directory /tmp/
diff --git a/test/lint/lint-python-dead-code-whitelist b/test/lint/lint-python-dead-code-whitelist
new file mode 100644
index 0000000000..2522c8fa1c
--- /dev/null
+++ b/test/lint/lint-python-dead-code-whitelist
@@ -0,0 +1,45 @@
+BadInputOutpointIndex # unused class (test/functional/data/invalid_txs.py)
+_.carbon_path # unused attribute (contrib/macdeploy/custom_dsstore.py)
+connection_lost # unused function (test/functional/test_framework/mininode.py)
+connection_made # unused function (test/functional/test_framework/mininode.py)
+_.converter # unused attribute (test/functional/test_framework/test_framework.py)
+_.daemon # unused attribute (test/functional/test_framework/socks5.py)
+data_received # unused function (test/functional/test_framework/mininode.py)
+DuplicateInput # unused class (test/functional/data/invalid_txs.py)
+_.filename # unused attribute (contrib/macdeploy/custom_dsstore.py)
+InvalidOPIFConstruction # unused class (test/functional/data/invalid_txs.py)
+_.is_compressed # unused property (test/functional/test_framework/key.py)
+legacy # unused variable (test/functional/test_framework/address.py)
+msg_generic # unused class (test/functional/test_framework/messages.py)
+NonexistentInput # unused class (test/functional/data/invalid_txs.py)
+on_addr # unused function (test/functional/test_framework/mininode.py)
+on_blocktxn # unused function (test/functional/test_framework/mininode.py)
+on_block # unused function (test/functional/test_framework/mininode.py)
+on_cmpctblock # unused function (test/functional/test_framework/mininode.py)
+on_feefilter # unused function (test/functional/test_framework/mininode.py)
+on_getaddr # unused function (test/functional/test_framework/mininode.py)
+on_getblocks # unused function (test/functional/test_framework/mininode.py)
+on_getblocktxn # unused function (test/functional/test_framework/mininode.py)
+on_getdata # unused function (test/functional/test_framework/mininode.py)
+on_getheaders # unused function (test/functional/test_framework/mininode.py)
+on_headers # unused function (test/functional/test_framework/mininode.py)
+on_inv # unused function (test/functional/test_framework/mininode.py)
+on_mempool # unused function (test/functional/test_framework/mininode.py)
+on_notfound # unused function (test/functional/test_framework/mininode.py)
+on_ping # unused function (test/functional/test_framework/mininode.py)
+on_pong # unused function (test/functional/test_framework/mininode.py)
+on_reject # unused function (test/functional/test_framework/mininode.py)
+on_sendcmpct # unused function (test/functional/test_framework/mininode.py)
+on_sendheaders # unused function (test/functional/test_framework/mininode.py)
+on_tx # unused function (test/functional/test_framework/mininode.py)
+on_verack # unused function (test/functional/test_framework/mininode.py)
+on_version # unused function (test/functional/test_framework/mininode.py)
+_.optionxform # unused attribute (test/util/bitcoin-util-test.py)
+OutputMissing # unused class (test/functional/data/invalid_txs.py)
+_.posix_path # unused attribute (contrib/macdeploy/custom_dsstore.py)
+profile_with_perf # unused function (test/functional/test_framework/test_node.py)
+SizeTooSmall # unused class (test/functional/data/invalid_txs.py)
+SpendNegative # unused class (test/functional/data/invalid_txs.py)
+SpendTooMuch # unused class (test/functional/data/invalid_txs.py)
+TooManySigops # unused class (test/functional/data/invalid_txs.py)
+verify_ecdsa # unused function (test/functional/test_framework/key.py)
diff --git a/test/lint/lint-python-dead-code.sh b/test/lint/lint-python-dead-code.sh
index 588ba428d7..77bf5990a7 100755
--- a/test/lint/lint-python-dead-code.sh
+++ b/test/lint/lint-python-dead-code.sh
@@ -15,5 +15,5 @@ fi
vulture \
--min-confidence 60 \
- --ignore-names "argtypes,connection_lost,connection_made,converter,data_received,daemon,errcheck,is_compressed,is_valid,verify_ecdsa,msg_generic,on_*,optionxform,restype,profile_with_perf" \
- $(git ls-files -- "*.py" ":(exclude)contrib/" ":(exclude)test/functional/data/invalid_txs.py")
+ $(git rev-parse --show-toplevel) \
+ $(dirname "${BASH_SOURCE[0]}")/lint-python-dead-code-whitelist