diff options
author | MarcoFalke <falke.marco@gmail.com> | 2021-07-28 19:52:14 +0200 |
---|---|---|
committer | MarcoFalke <falke.marco@gmail.com> | 2021-07-30 11:24:41 +0200 |
commit | fa4e6afdae7b82df638b60edf37ac36d57a8cb4f (patch) | |
tree | 716dcf16ea1a32b2d1ce70199752b5bedfe64140 | |
parent | fa384fdd0b7af73d81fa9619c5fba779452cd2af (diff) |
Remove unused CSubNet serialize code
-rw-r--r-- | src/netaddress.h | 18 | ||||
-rw-r--r-- | src/test/fuzz/deserialize.cpp | 11 |
2 files changed, 0 insertions, 29 deletions
diff --git a/src/netaddress.h b/src/netaddress.h index 5e1d9d2a6f..c81f9fd5d8 100644 --- a/src/netaddress.h +++ b/src/netaddress.h @@ -536,24 +536,6 @@ class CSubNet friend bool operator==(const CSubNet& a, const CSubNet& b); friend bool operator!=(const CSubNet& a, const CSubNet& b) { return !(a == b); } friend bool operator<(const CSubNet& a, const CSubNet& b); - - SERIALIZE_METHODS(CSubNet, obj) - { - READWRITE(obj.network); - if (obj.network.IsIPv4()) { - // Before commit 102867c587f5f7954232fb8ed8e85cda78bb4d32, CSubNet used the last 4 bytes of netmask - // to store the relevant bytes for an IPv4 mask. For compatibility reasons, keep doing so in - // serialized form. - unsigned char dummy[12] = {0}; - READWRITE(dummy); - READWRITE(MakeSpan(obj.netmask).first(4)); - } else { - READWRITE(obj.netmask); - } - READWRITE(obj.valid); - // Mark invalid if the result doesn't pass sanity checking. - SER_READ(obj, if (obj.valid) obj.valid = obj.SanityCheck()); - } }; /** A combination of a network address (CNetAddr) and a (TCP) port */ diff --git a/src/test/fuzz/deserialize.cpp b/src/test/fuzz/deserialize.cpp index 721e4360d0..63f75bc9a0 100644 --- a/src/test/fuzz/deserialize.cpp +++ b/src/test/fuzz/deserialize.cpp @@ -142,17 +142,6 @@ FUZZ_TARGET_DESERIALIZE(script_deserialize, { CScript script; DeserializeFromFuzzingInput(buffer, script); }) -FUZZ_TARGET_DESERIALIZE(sub_net_deserialize, { - CSubNet sub_net_1; - DeserializeFromFuzzingInput(buffer, sub_net_1, INIT_PROTO_VERSION); - AssertEqualAfterSerializeDeserialize(sub_net_1, INIT_PROTO_VERSION); - CSubNet sub_net_2; - DeserializeFromFuzzingInput(buffer, sub_net_2, INIT_PROTO_VERSION | ADDRV2_FORMAT); - AssertEqualAfterSerializeDeserialize(sub_net_2, INIT_PROTO_VERSION | ADDRV2_FORMAT); - CSubNet sub_net_3; - DeserializeFromFuzzingInput(buffer, sub_net_3); - AssertEqualAfterSerializeDeserialize(sub_net_3, INIT_PROTO_VERSION | ADDRV2_FORMAT); -}) FUZZ_TARGET_DESERIALIZE(tx_in_deserialize, { CTxIn tx_in; DeserializeFromFuzzingInput(buffer, tx_in); |