diff options
author | MarcoFalke <falke.marco@gmail.com> | 2020-12-14 10:52:25 +0100 |
---|---|---|
committer | MarcoFalke <falke.marco@gmail.com> | 2020-12-14 10:52:28 +0100 |
commit | 096bd374da28904014ceb3a7245c5ee0de54bd6f (patch) | |
tree | f70b6b8c960c44ee3224571d9a5915eab12d9f43 | |
parent | 25bc840e038f5cc3a1d70d6fbaf1dc2eb2c6e460 (diff) | |
parent | 4b7b58b3fef5b9566a475871c441ed6ae73af89e (diff) |
Merge #20592: doc: update wtxidrelay documentation per BIP339
4b7b58b3fef5b9566a475871c441ed6ae73af89e Update net_processing WTXID documentation per BIP339 (Jon Atack)
Pull request description:
BIP339 currently states:
*The wtxidrelay message MUST be sent in response to a version message from a peer whose protocol version is >= 70016 and prior to sending a verack. A wtxidrelay message received after a verack message MUST be ignored or treated as invalid.*
ACKs for top commit:
MarcoFalke:
ACK 4b7b58b3fef5b9566a475871c441ed6ae73af89e
practicalswift:
ACK 4b7b58b3fef5b9566a475871c441ed6ae73af89e
RiccardoMasutti:
ACK 4b7b58b
Tree-SHA512: 58ca6b197618cc73c70aa5de0a2d9d89a68b4cad9d5a708278ef17a9d6854d4362bcc384b6d29696642924977204a8fc120b31e91e2d97b6072b7b0d41c9f2dc
-rw-r--r-- | src/net_processing.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/net_processing.cpp b/src/net_processing.cpp index b61e640f8e..d9f2c7b146 100644 --- a/src/net_processing.cpp +++ b/src/net_processing.cpp @@ -2488,8 +2488,8 @@ void PeerManager::ProcessMessage(CNode& pfrom, const std::string& msg_type, CDat return; } - // Feature negotiation of wtxidrelay should happen between VERSION and - // VERACK, to avoid relay problems from switching after a connection is up + // Feature negotiation of wtxidrelay must happen between VERSION and VERACK + // to avoid relay problems from switching after a connection is up. if (msg_type == NetMsgType::WTXIDRELAY) { if (pfrom.fSuccessfullyConnected) { // Disconnect peers that send wtxidrelay message after VERACK; this |