diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2020-09-26 17:45:56 +0200 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2020-09-26 17:45:59 +0200 |
| commit | 055abfbc5a4d5e6ffc0011ab045949e08fff0f84 (patch) | |
| tree | 81c1ad42b11d11a05d0ca0ada3f802b2f9d9ec9c | |
| parent | 4f45ea1f739349d75ef4273bfb369395eec2fb39 (diff) | |
| parent | 92e28fa8b2590cce0e8f0adadae80e46cb63a9ef (diff) | |
Merge #20023: test: remove unused constants in functional tests
92e28fa8b2590cce0e8f0adadae80e46cb63a9ef test: remove unused constants in functional tests (Sebastian Falbesoner)
Pull request description:
This mini-PR gets rid of constants in functional tests that are not used anymore. Found by [vulture ](https://pypi.org/project/vulture/)via the following script that has been lying around here locally for quite some time (I think it was once proposed by practicalswift, but I don't remember the concrete topic/PR):
```
#!/bin/sh
for F in $(git ls-files -- "*.py"); do vulture "$F" | grep "unused variable"; done
```
ACKs for top commit:
practicalswift:
ACK 92e28fa8b2590cce0e8f0adadae80e46cb63a9ef: patch looks correct.
Tree-SHA512: 16516abc8014207bcefdf0545dffaecff1fbba66f45b54c02371dcfd1f18194855c6b72598c11b5407009561eafe8048d47af3471f0efb1795d52477d5a0232e
| -rwxr-xr-x | test/functional/p2p_segwit.py | 1 | ||||
| -rwxr-xr-x | test/functional/wallet_multiwallet.py | 2 |
2 files changed, 0 insertions, 3 deletions
diff --git a/test/functional/p2p_segwit.py b/test/functional/p2p_segwit.py index e190df403a..d79ed449e5 100755 --- a/test/functional/p2p_segwit.py +++ b/test/functional/p2p_segwit.py @@ -89,7 +89,6 @@ from test_framework.util import ( # The versionbit bit used to signal activation of SegWit VB_WITNESS_BIT = 1 -VB_PERIOD = 144 VB_TOP_BITS = 0x20000000 MAX_SIGOP_COST = 80000 diff --git a/test/functional/wallet_multiwallet.py b/test/functional/wallet_multiwallet.py index aaf050ebf7..f0be271c66 100755 --- a/test/functional/wallet_multiwallet.py +++ b/test/functional/wallet_multiwallet.py @@ -21,8 +21,6 @@ from test_framework.util import ( get_rpc_proxy, ) -FEATURE_LATEST = 169900 - got_loading_error = False def test_load_unload(node, name): global got_loading_error |