diff options
author | MarcoFalke <falke.marco@gmail.com> | 2022-01-31 10:19:32 +0100 |
---|---|---|
committer | MarcoFalke <falke.marco@gmail.com> | 2022-01-31 10:09:11 +0100 |
commit | fa4595deb334f14dac9ba481d786a823e0f0fde1 (patch) | |
tree | 6b0314f236128510c6e7ee65debe579a36533813 | |
parent | 5f4c07b79902fb3780c01a7fec3ad8bff0c51189 (diff) | |
download | bitcoin-fa4595deb334f14dac9ba481d786a823e0f0fde1.tar.xz |
test: Remove random line number feature from feature_init.py
This is needed for the next commit.
Also, it doesn't really test anything novel. wait_for_debug_log is
inherently racy, so will randomly terminate at the exact point or later.
So the randomization is already sufficiently covered by the existing
test.
-rwxr-xr-x | test/functional/feature_init.py | 31 |
1 files changed, 0 insertions, 31 deletions
diff --git a/test/functional/feature_init.py b/test/functional/feature_init.py index 4b56b0c26b..427f9f10ef 100755 --- a/test/functional/feature_init.py +++ b/test/functional/feature_init.py @@ -85,37 +85,6 @@ class InitStressTest(BitcoinTestFramework): check_clean_start() self.stop_node(0) - self.log.info( - f"Terminate at some random point in the init process (max logs: {num_total_logs})") - - for _ in range(40): - num_logs = len(Path(node.debug_log_path).read_text().splitlines()) - additional_lines = random.randint(1, num_total_logs) - self.log.debug(f"Starting node and will exit after {additional_lines} lines") - node.start(extra_args=['-txindex=1']) - logfile = open(node.debug_log_path, 'rb') - - MAX_SECS_TO_WAIT = 10 - start = time.time() - num_lines = 0 - - while True: - line = logfile.readline() - if line: - num_lines += 1 - - if num_lines >= (num_logs + additional_lines) or \ - (time.time() - start) > MAX_SECS_TO_WAIT: - self.log.debug(f"Terminating node after {num_lines} log lines seen") - sigterm_node() - break - - if node.process.poll() is not None: - raise AssertionError("node failed to start") - - check_clean_start() - self.stop_node(0) - self.log.info("Test startup errors after removing certain essential files") files_to_disturb = { |