diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2021-07-25 10:19:01 +0200 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2021-07-25 10:19:04 +0200 |
| commit | 8bc4a11409aed8054d27bdaa8a2ad20d10195de5 (patch) | |
| tree | 044c640268b65d128b5c96ae906c7afe6817e966 | |
| parent | 401db600b074fe12d452a4f958316569a1dc096f (diff) | |
| parent | 179a051704321ba40277a5855d6ac0dbb45689dd (diff) | |
Merge bitcoin/bitcoin#22442: util: improves error messages on get_previous_releases script
179a051704321ba40277a5855d6ac0dbb45689dd util: improves error messages on get_previous_releases script (Nelson Galdeman)
Pull request description:
When previous releases are fetched and the specified version wasn't added to the checksum list we used to get a "Checksum did not match" which isn't true (https://github.com/bitcoin-core/bitcoincore.org/issues/753#issuecomment-879546719).
If the specified version number is not on the list, it now logs cannot do the comparison instead.
ACKs for top commit:
practicalswift:
cr ACK 179a051704321ba40277a5855d6ac0dbb45689dd
theStack:
tACK 179a051704321ba40277a5855d6ac0dbb45689dd, tested on Debian bullseye/sid
Tree-SHA512: 2a07ce75232f853fd311c43581f8faf12d423668946ae6ad784feece5b4d0edd57fc018ba1f0c5a73bfaccb326e0df9a643580d16bf427c1ec3ff34a9cdbc80c
| -rwxr-xr-x | test/get_previous_releases.py | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/test/get_previous_releases.py b/test/get_previous_releases.py index 01e4ef47a7..e92bb402b5 100755 --- a/test/get_previous_releases.py +++ b/test/get_previous_releases.py @@ -112,7 +112,11 @@ def download_binary(tag, args) -> int: tarballHash = hasher.hexdigest() if tarballHash not in SHA256_SUMS or SHA256_SUMS[tarballHash] != tarball: - print("Checksum did not match") + if tarball in SHA256_SUMS.values(): + print("Checksum did not match") + return 1 + + print("Checksum for given version doesn't exist") return 1 print("Checksum matched") |