diff options
| author | fanquake <fanquake@gmail.com> | 2024-02-29 14:37:44 -0500 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2024-02-29 14:37:49 -0500 |
| commit | 9057598605b8685adfd43db85f2fc96bf7c0d5a5 (patch) | |
| tree | cbea306413456dd557d9f25d44005e5b4d56f9f2 | |
| parent | 22a5ccfb06429c3b0e111a191e7ba71d98a1d198 (diff) | |
| parent | 6ee3997d03e456655e3c44abf1e15270c423ed41 (diff) | |
Merge bitcoin/bitcoin#29516: test: removes unnecessary check from validation_tests
6ee3997d03e456655e3c44abf1e15270c423ed41 test: removes unnecessary check from validation_tests (Sergi Delgado Segura)
Pull request description:
An unnecessary check was added to the block mutation tests in #29412 where IsBlockMutated is returning true for the invalid reasons: we try to check mutation via transaction duplication, but the merkle root is not updated before the check, therefore the check fails because the provided root and the computed root differ, but not because the block contains the same transaction twice.
Notice that a proper check to test the duplication case is added a few lines later, so this check is just meaningless and can be removed. Check https://github.com/bitcoin/bitcoin/pull/29412#discussion_r1506490281 for context.
ACKs for top commit:
maflcko:
ACK 6ee3997d03e456655e3c44abf1e15270c423ed41
dergoegge:
utACK 6ee3997d03e456655e3c44abf1e15270c423ed41
BrandonOdiwuor:
utACK 6ee3997d03e456655e3c44abf1e15270c423ed41
Tree-SHA512: e4627668091dda5f589e4c15edac39dc84aabc9b34b8f7fadbf512beb7111d5477e1b69567a34b4a657e48ba66dfb864db5ff37c9bbe3ff24cd32931b2dd89e6
| -rw-r--r-- | src/test/validation_tests.cpp | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/test/validation_tests.cpp b/src/test/validation_tests.cpp index c6f6ac3bdb..93a884be6d 100644 --- a/src/test/validation_tests.cpp +++ b/src/test/validation_tests.cpp @@ -233,7 +233,6 @@ BOOST_AUTO_TEST_CASE(block_malleation) // Block with two transactions is mutated if any node is duplicate. { block.vtx[1] = block.vtx[0]; - BOOST_CHECK(is_mutated(block, /*check_witness_root=*/false)); HashWriter hasher; hasher.write(block.vtx[0]->GetHash()); hasher.write(block.vtx[1]->GetHash()); |