diff options
| author | MacroFake <falke.marco@gmail.com> | 2022-05-25 10:02:21 +0200 |
|---|---|---|
| committer | MacroFake <falke.marco@gmail.com> | 2022-05-25 10:02:24 +0200 |
| commit | 8c721fff3a007db613b22464b40fe7cd6b1ead80 (patch) | |
| tree | 51c12d025fb42005b49ab9bad6549399542cfba8 | |
| parent | bd57b4e0c01bcf9f809fcad9d39649540767a444 (diff) | |
| parent | 295ff61934f8adea04dabb47695070e2cfd0548e (diff) | |
Merge bitcoin/bitcoin#25192: test: add coverage for unknown value to -blockfilterindex
295ff61934f8adea04dabb47695070e2cfd0548e test: add coverage for unknown -blockfilterindex (brunoerg)
Pull request description:
This PR adds test coverage for the following init error:
https://github.com/bitcoin/bitcoin/blob/44037a29129a830fd9c9580f0818387756cfd7d3/src/init.cpp#L844
Passing an unknown value to -blockfilterindex should throw an error.
ACKs for top commit:
dunxen:
cr-ACK 295ff61
Tree-SHA512: 1444903cf0696406c485ce0575f951d527fe7d699094d5845622c0b57c954d6d7dcf1e78ef0c4e8b9b26f53b79583f07fec0e8d8e7f04aa744d2a8cd98329db9
| -rwxr-xr-x | test/functional/p2p_blockfilters.py | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/test/functional/p2p_blockfilters.py b/test/functional/p2p_blockfilters.py index 2ffc825acd..ef12b5f6b7 100755 --- a/test/functional/p2p_blockfilters.py +++ b/test/functional/p2p_blockfilters.py @@ -250,6 +250,11 @@ class CompactFiltersTest(BitcoinTestFramework): msg = "Error: Cannot set -peerblockfilters without -blockfilterindex." self.nodes[0].assert_start_raises_init_error(expected_msg=msg) + self.log.info("Test unknown value to -blockfilterindex raises an error") + self.nodes[0].extra_args = ["-blockfilterindex=abc"] + msg = "Error: Unknown -blockfilterindex value abc." + self.nodes[0].assert_start_raises_init_error(expected_msg=msg) + self.log.info("Test -blockfilterindex with -reindex-chainstate raises an error") self.nodes[0].assert_start_raises_init_error( expected_msg='Error: -reindex-chainstate option is not compatible with -blockfilterindex. ' |