Merge #14279: 0.14.3 release notes, manpage and version bumpv0.14.3

02857b121c13b6ffebcf4c83771b34c1124e7bd2 doc: update manpages for 0.14.3 (Sjors Provoost)
5138e9e615d037462096787a36fdc7e812dbf141 doc: 0.14.3 release notes (Sjors Provoost)
f503ff1ecde0c961b520dec2aef148fda00ad06d build: Bump version to 0.14.3 (Sjors Provoost)

Pull request description:

  I left a bunch of test and documentation commits out of the release notes.

Tree-SHA512: 978297ad03fe1c384e4ff6d6a75cbdae6b7e2856c1293747c01735fd17ddcaafbf65c4da2acfb203a8b0d556ebcfc76eaccf450ad7296c6c2ea61979c15ab0c2

6 files changed, 64 insertions, 102 deletions

diff --git a/configure.ac b/configure.ac
index 0894c7197c..bd22678c8b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2,7 +2,7 @@ dnl require autoconf 2.60 (AS_ECHO/AS_ECHO_N)
 AC_PREREQ([2.60])
 define(_CLIENT_VERSION_MAJOR, 0)
 define(_CLIENT_VERSION_MINOR, 14)
-define(_CLIENT_VERSION_REVISION, 2)
+define(_CLIENT_VERSION_REVISION, 3)
 define(_CLIENT_VERSION_BUILD, 0)
 define(_CLIENT_VERSION_IS_RELEASE, true)
 define(_COPYRIGHT_YEAR, 2017)
diff --git a/doc/man/bitcoin-cli.1 b/doc/man/bitcoin-cli.1
index 77ee12f04a..89d70ea5bc 100644
--- a/doc/man/bitcoin-cli.1
+++ b/doc/man/bitcoin-cli.1
@@ -1,9 +1,9 @@
-.\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.47.3.
-.TH BITCOIN-CLI "1" "June 2017" "bitcoin-cli v0.14.2.0" "User Commands"
+.\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.46.4.
+.TH BITCOIN-CLI "1" "September 2018" "bitcoin-cli v0.14.3.0" "User Commands"
 .SH NAME
-bitcoin-cli \- manual page for bitcoin-cli v0.14.2.0
+bitcoin-cli \- manual page for bitcoin-cli v0.14.3.0
 .SH DESCRIPTION
-Bitcoin Core RPC client version v0.14.2.0
+Bitcoin Core RPC client version v0.14.3.0
 .SS "Usage:"
 .TP
 bitcoin\-cli [options] <command> [params]
diff --git a/doc/man/bitcoin-qt.1 b/doc/man/bitcoin-qt.1
index a51d4f6316..4c7bdaf35e 100644
--- a/doc/man/bitcoin-qt.1
+++ b/doc/man/bitcoin-qt.1
@@ -1,9 +1,9 @@
-.\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.47.3.
-.TH BITCOIN-QT "1" "June 2017" "bitcoin-qt v0.14.2.0" "User Commands"
+.\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.46.4.
+.TH BITCOIN-QT "1" "September 2018" "bitcoin-qt v0.14.3.0" "User Commands"
 .SH NAME
-bitcoin-qt \- manual page for bitcoin-qt v0.14.2.0
+bitcoin-qt \- manual page for bitcoin-qt v0.14.3.0
 .SH DESCRIPTION
-Bitcoin Core version v0.14.2.0 (64\-bit)
+Bitcoin Core version v0.14.3.0 (64\-bit)
 Usage:
 .IP
 bitcoin\-qt [command\-line options]
@@ -72,7 +72,7 @@ Extra transactions to keep in memory for compact block reconstructions
 .HP
 \fB\-par=\fR<n>
 .IP
-Set the number of script verification threads (\fB\-6\fR to 16, 0 = auto, <0 =
+Set the number of script verification threads (\fB\-4\fR to 16, 0 = auto, <0 =
 leave that many cores free, default: 0)
 .HP
 \fB\-pid=\fR<file>
diff --git a/doc/man/bitcoin-tx.1 b/doc/man/bitcoin-tx.1
index 04ec7b9553..3565f90d09 100644
--- a/doc/man/bitcoin-tx.1
+++ b/doc/man/bitcoin-tx.1
@@ -1,9 +1,9 @@
-.\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.47.3.
-.TH BITCOIN-TX "1" "June 2017" "bitcoin-tx v0.14.2.0" "User Commands"
+.\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.46.4.
+.TH BITCOIN-TX "1" "September 2018" "bitcoin-tx v0.14.3.0" "User Commands"
 .SH NAME
-bitcoin-tx \- manual page for bitcoin-tx v0.14.2.0
+bitcoin-tx \- manual page for bitcoin-tx v0.14.3.0
 .SH DESCRIPTION
-Bitcoin Core bitcoin\-tx utility version v0.14.2.0
+Bitcoin Core bitcoin\-tx utility version v0.14.3.0
 .SS "Usage:"
 .TP
 bitcoin\-tx [options] <hex\-tx> [commands]
diff --git a/doc/man/bitcoind.1 b/doc/man/bitcoind.1
index b3d8e0b9a3..928c2c3016 100644
--- a/doc/man/bitcoind.1
+++ b/doc/man/bitcoind.1
@@ -1,9 +1,9 @@
-.\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.47.3.
-.TH BITCOIND "1" "June 2017" "bitcoind v0.14.2.0" "User Commands"
+.\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.46.4.
+.TH BITCOIND "1" "September 2018" "bitcoind v0.14.3.0" "User Commands"
 .SH NAME
-bitcoind \- manual page for bitcoind v0.14.2.0
+bitcoind \- manual page for bitcoind v0.14.3.0
 .SH DESCRIPTION
-Bitcoin Core Daemon version v0.14.2.0
+Bitcoin Core Daemon version v0.14.3.0
 .SS "Usage:"
 .TP
 bitcoind [options]
@@ -77,7 +77,7 @@ Extra transactions to keep in memory for compact block reconstructions
 .HP
 \fB\-par=\fR<n>
 .IP
-Set the number of script verification threads (\fB\-6\fR to 16, 0 = auto, <0 =
+Set the number of script verification threads (\fB\-4\fR to 16, 0 = auto, <0 =
 leave that many cores free, default: 0)
 .HP
 \fB\-pid=\fR<file>
diff --git a/doc/release-notes.md b/doc/release-notes.md
index 9c8c62d1bd..1dde26a628 100644
--- a/doc/release-notes.md
+++ b/doc/release-notes.md
@@ -1,9 +1,9 @@
-Bitcoin Core version 0.14.2 is now available from:
+Bitcoin Core version 0.14.3 is now available from:
 
-  <https://bitcoin.org/bin/bitcoin-core-0.14.2/>
+  <https://bitcoin.org/bin/bitcoin-core-0.14.3/>
 
 This is a new minor version release, including various bugfixes and
-performance improvements, as well as updated translations.
+performance improvements.
 
 Please report bugs using the issue tracker at github:
 
@@ -30,69 +30,12 @@ frequently tested on them.
 Notable changes
 ===============
 
-Low-level RPC changes
----------------------
-
-- Error codes have been updated to be more accurate for the following error cases:
-  - `getblock` now returns RPC_MISC_ERROR if the block can't be found on disk (for
-  example if the block has been pruned). Previously returned RPC_INTERNAL_ERROR.
-  - `pruneblockchain` now returns RPC_MISC_ERROR if the blocks cannot be pruned
-  because the node is not in pruned mode. Previously returned RPC_METHOD_NOT_FOUND.
-  - `pruneblockchain` now returns RPC_INVALID_PARAMETER if the blocks cannot be pruned
-  because the supplied timestamp is too late. Previously returned RPC_INTERNAL_ERROR.
-  - `pruneblockchain` now returns RPC_MISC_ERROR if the blocks cannot be pruned
-  because the blockchain is too short. Previously returned RPC_INTERNAL_ERROR.
-  - `setban` now returns RPC_CLIENT_INVALID_IP_OR_SUBNET if the supplied IP address
-  or subnet is invalid. Previously returned RPC_CLIENT_NODE_ALREADY_ADDED.
-  - `setban` now returns RPC_CLIENT_INVALID_IP_OR_SUBNET if the user tries to unban
-  a node that has not previously been banned. Previously returned RPC_MISC_ERROR.
-  - `removeprunedfunds` now returns RPC_WALLET_ERROR if bitcoind is unable to remove
-  the transaction. Previously returned RPC_INTERNAL_ERROR.
-  - `removeprunedfunds` now returns RPC_INVALID_PARAMETER if the transaction does not
-  exist in the wallet. Previously returned RPC_INTERNAL_ERROR.
-  - `fundrawtransaction` now returns RPC_INVALID_ADDRESS_OR_KEY if an invalid change
-  address is provided. Previously returned RPC_INVALID_PARAMETER.
-  - `fundrawtransaction` now returns RPC_WALLET_ERROR if bitcoind is unable to create
-  the transaction. The error message provides further details. Previously returned
-  RPC_INTERNAL_ERROR.
-  - `bumpfee` now returns RPC_INVALID_PARAMETER if the provided transaction has
-  descendants in the wallet. Previously returned RPC_MISC_ERROR.
-  - `bumpfee` now returns RPC_INVALID_PARAMETER if the provided transaction has
-  descendants in the mempool. Previously returned RPC_MISC_ERROR.
-  - `bumpfee` now returns RPC_WALLET_ERROR if the provided transaction has
-  has been mined or conflicts with a mined transaction. Previously returned
-  RPC_INVALID_ADDRESS_OR_KEY.
-  - `bumpfee` now returns RPC_WALLET_ERROR if the provided transaction is not
-  BIP 125 replaceable. Previously returned RPC_INVALID_ADDRESS_OR_KEY.
-  - `bumpfee` now returns RPC_WALLET_ERROR if the provided transaction has already
-  been bumped by a different transaction. Previously returned RPC_INVALID_REQUEST.
-  - `bumpfee` now returns RPC_WALLET_ERROR if the provided transaction contains
-  inputs which don't belong to this wallet. Previously returned RPC_INVALID_ADDRESS_OR_KEY.
-  - `bumpfee` now returns RPC_WALLET_ERROR if the provided transaction has multiple change
-  outputs. Previously returned RPC_MISC_ERROR.
-  - `bumpfee` now returns RPC_WALLET_ERROR if the provided transaction has no change
-  output. Previously returned RPC_MISC_ERROR.
-  - `bumpfee` now returns RPC_WALLET_ERROR if the fee is too high. Previously returned
-  RPC_MISC_ERROR.
-  - `bumpfee` now returns RPC_WALLET_ERROR if the fee is too low. Previously returned
-  RPC_MISC_ERROR.
-  - `bumpfee` now returns RPC_WALLET_ERROR if the change output is too small to bump the
-  fee. Previously returned RPC_MISC_ERROR.
-
-miniupnp CVE-2017-8798
-----------------------------
-
-Bundled miniupnpc was updated to 2.0.20170509. This fixes an integer signedness error
-(present in MiniUPnPc v1.4.20101221 through v2.0) that allows remote attackers
-(within the LAN) to cause a denial of service or possibly have unspecified
-other impact.
-
-This only affects users that have explicitly enabled UPnP through the GUI
-setting or through the `-upnp` option, as since the last UPnP vulnerability
-(in Bitcoin Core 0.10.3) it has been disabled by default.
-
-If you use this option, it is recommended to upgrade to this version as soon as
-possible.
+Denial-of-Service vulnerability CVE-2018-17144
+ -------------------------------
+
+A denial-of-service vulnerability exploitable by miners has been discovered in
+Bitcoin Core versions 0.14.0 up to 0.16.2. It is recommended to upgrade any of
+the vulnerable versions to 0.14.3, 0.15.2 or 0.16.3 as soon as possible.
 
 Known Bugs
 ==========
@@ -103,7 +46,7 @@ smart fee slider. It will only present an approximate fee calculated using the
 default target. The fee calculated using the correct target is still applied to
 the transaction and shown in the final send confirmation dialog.
 
-0.14.2 Change log
+0.14.3 Change log
 =================
 
 Detailed release notes follow. This overview includes changes that affect
@@ -111,41 +54,60 @@ behavior, not code moves, refactors and string updates. For convenience in locat
 the code changes and accompanying discussion, both the pull request and
 git merge commit are mentioned.
 
+### Consensus
+- #14247 `52965fb` Fix crash bug with duplicate inputs within a transaction (TheBlueMatt, sdaftuar)
+ 
 ### RPC and other APIs
-- #10410 `321419b` Fix importwallet edge case rescan bug (ryanofsky)
+
+- #10445 `87a21d5` Fix: make CCoinsViewDbCursor::Seek work for missing keys (Pieter Wuille, Gregory Maxwell)
+- #9853 Return correct error codes in setban(), fundrawtransaction(), removeprunedfunds(), bumpfee(), blockchain.cpp (John Newbery)
+
 
 ### P2P protocol and network code
-- #10424 `37a8fc5` Populate services in GetLocalAddress (morcos)
-- #10441 `9e3ad50` Only enforce expected services for half of outgoing connections (theuni)
+
+- #10234 `d289b56` [net] listbanned RPC and QT should show correct banned subnets (John Newbery)
 
 ### Build system
-- #10414 `ffb0c4b` miniupnpc 2.0.20170509 (fanquake)
-- #10228 `ae479bc` Regenerate bitcoin-config.h as necessary (theuni)
+
 
 ### Miscellaneous
-- #10245 `44a17f2` Minor fix in build documentation for FreeBSD 11 (shigeya)
-- #10215 `0aee4a1` Check interruptNet during dnsseed lookups (TheBlueMatt)
+
+- #10451 `3612219` contrib/init/bitcoind.openrcconf: Don't disable wallet by default (Luke Dashjr)
+- #10250 `e23cef0` Fix some empty vector references (Pieter Wuille)
+- #10196 `d28d583` PrioritiseTransaction updates the mempool tx counter (Suhas Daftuar)
+- #9497 `e207342` Fix CCheckQueue IsIdle (potential) race condition and remove dangerous constructors. (Jeremy Rubin)
 
 ### GUI
-- #10231 `1e936d7` Reduce a significant cs_main lock freeze (jonasschnelli)
+
+- #9481 `7abe7bb` Give fallback fee a reasonable indent (Luke Dashjr)
+- #9481 `3e4d7bf` Qt/Send: Figure a decent warning colour from theme (Luke Dashjr)
+- #9481 `e207342` Show more significant warning if we fall back to the default fee (Jonas Schnelli)
 
 ### Wallet
-- #10294 `1847642` Unset change position when there is no change (instagibbs)
+
+- #10308 `28b8b8b` Securely erase potentially sensitive keys/values (tjps)
+- #10265 `ff13f59` Make sure pindex is non-null before possibly referencing in LogPrintf call. (Karl-Johan Alm)
 
 Credits
 =======
 
 Thanks to everyone who directly contributed to this release:
 
-- Alex Morcos
 - Cory Fields
+- CryptAxe
 - fanquake
-- Gregory Sanders
+- Jeremy Rubin
+- John Newbery
 - Jonas Schnelli
+- Gregory Maxwell
+- Karl-Johan Alm
+- Luke Dashjr
+- MarcoFalke
 - Matt Corallo
-- Russell Yanofsky
-- Shigeya Suzuki
+- Mikerah
+- Pieter Wuille
+- practicalswift
+- Suhas Daftuar
+- Thomas Snider
+- Tjps
 - Wladimir J. van der Laan
-
-As well as everyone that helped translating on [Transifex](https://www.transifex.com/projects/p/bitcoin/).
-