diff options
| author | Tyler Chambers <tyler@iheartapis.com> | 2020-11-08 16:35:13 -0500 |
|---|---|---|
| committer | Tyler Chambers <tyler@iheartapis.com> | 2020-11-09 10:21:51 -0500 |
| commit | b6121edf70a8d50fd16ddbba0c3168e5e49bfc2e (patch) | |
| tree | 512a3d3a835be826adff9f42f4f4852033d8eef8 | |
| parent | 7e373294a5ae819099c39d9d03d1f5a311d63cfc (diff) | |
| download | bitcoin-b6121edf70a8d50fd16ddbba0c3168e5e49bfc2e.tar.xz | |
swapped "is" for "==" in literal comparison
update lint-python.sh to include check F632
| -rwxr-xr-x | contrib/devtools/security-check.py | 2 | ||||
| -rwxr-xr-x | test/lint/lint-python.sh | 1 |
2 files changed, 2 insertions, 1 deletions
diff --git a/contrib/devtools/security-check.py b/contrib/devtools/security-check.py index dc74de9198..02615edb54 100755 --- a/contrib/devtools/security-check.py +++ b/contrib/devtools/security-check.py @@ -62,7 +62,7 @@ def get_ELF_program_headers(executable): splitline = [x.strip() for x in line.split()] flags = splitline[ofs_flags] # check for 'R', ' E' - if splitline[ofs_flags + 1] is 'E': + if splitline[ofs_flags + 1] == 'E': flags += ' E' headers.append((typ, flags, [])) count += 1 diff --git a/test/lint/lint-python.sh b/test/lint/lint-python.sh index 72e8ef7c7d..4fc130497b 100755 --- a/test/lint/lint-python.sh +++ b/test/lint/lint-python.sh @@ -55,6 +55,7 @@ enabled=( F621 # too many expressions in an assignment with star-unpacking F622 # two or more starred expressions in an assignment (a, *b, *c = d) F631 # assertion test is a tuple, which are always True + F632 # use ==/!= to compare str, bytes, and int literals F701 # a break statement outside of a while or for loop F702 # a continue statement outside of a while or for loop F703 # a continue statement in a finally block in a loop |