diff options
| author | practicalswift <practicalswift@users.noreply.github.com> | 2018-10-29 09:15:11 +0100 |
|---|---|---|
| committer | practicalswift <practicalswift@users.noreply.github.com> | 2018-11-06 17:32:13 +0100 |
| commit | c5fd143edb85d0c181e21a429f9e29d12a611831 (patch) | |
| tree | ff7260b262bf078cb026f0560ee8643ef8d1879e | |
| parent | e70cc8983c570bbacee37a67df86b1bf959894df (diff) | |
Use ToLower(...) instead of std::tolower
| -rw-r--r-- | src/uint256.cpp | 2 | ||||
| -rw-r--r-- | src/util/system.cpp | 2 | ||||
| -rwxr-xr-x | test/lint/lint-locale-dependence.sh | 2 |
3 files changed, 2 insertions, 4 deletions
diff --git a/src/uint256.cpp b/src/uint256.cpp index d9da668036..b723f9ee54 100644 --- a/src/uint256.cpp +++ b/src/uint256.cpp @@ -33,7 +33,7 @@ void base_blob<BITS>::SetHex(const char* psz) psz++; // skip 0x - if (psz[0] == '0' && tolower(psz[1]) == 'x') + if (psz[0] == '0' && ToLower((unsigned char)psz[1]) == 'x') psz += 2; // hex string to uint diff --git a/src/util/system.cpp b/src/util/system.cpp index 4f5dd2d6e9..633b616dc3 100644 --- a/src/util/system.cpp +++ b/src/util/system.cpp @@ -422,7 +422,7 @@ bool ArgsManager::ParseParameters(int argc, const char* const argv[], std::strin key.erase(is_index); } #ifdef WIN32 - std::transform(key.begin(), key.end(), key.begin(), ::tolower); + std::transform(key.begin(), key.end(), key.begin(), ToLower); if (key[0] == '/') key[0] = '-'; #endif diff --git a/test/lint/lint-locale-dependence.sh b/test/lint/lint-locale-dependence.sh index 59881ce882..2765ebe5c7 100755 --- a/test/lint/lint-locale-dependence.sh +++ b/test/lint/lint-locale-dependence.sh @@ -15,10 +15,8 @@ KNOWN_VIOLATIONS=( "src/test/getarg_tests.cpp.*split" "src/torcontrol.cpp:.*atoi" "src/torcontrol.cpp:.*strtol" - "src/uint256.cpp:.*tolower" "src/util/system.cpp:.*atoi" "src/util/system.cpp:.*fprintf" - "src/util/system.cpp:.*tolower" "src/util/strencodings.cpp:.*atoi" "src/util/strencodings.cpp:.*strtol" "src/util/strencodings.cpp:.*strtoul" |