diff options
| author | Jon Atack <jon@atack.com> | 2019-07-26 11:30:51 +0200 |
|---|---|---|
| committer | Jon Atack <jon@atack.com> | 2019-07-27 19:43:44 +0200 |
| commit | 07e01d6258831fd2dfef959a405b3dfe4e88c3c1 (patch) | |
| tree | bc93586e3ae812b0dcee507cc41c331636162f06 | |
| parent | a54a12046e98c57512715041d30ecf2f0ab8f6dd (diff) | |
rpc: sendrawtransaction unconditionality/privacy note
In sendrawtransaction RPCHelpMan, mention unconditionality and privacy
as per http://www.erisian.com.au/bitcoin-core-dev/log-2019-07-25.html#l-522
Thank you to MarcoFalke and laanwj for their review and suggestions.
| -rw-r--r-- | src/rpc/rawtransaction.cpp | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/src/rpc/rawtransaction.cpp b/src/rpc/rawtransaction.cpp index 532765b3d8..0ab504de06 100644 --- a/src/rpc/rawtransaction.cpp +++ b/src/rpc/rawtransaction.cpp @@ -760,7 +760,10 @@ static UniValue signrawtransactionwithkey(const JSONRPCRequest& request) static UniValue sendrawtransaction(const JSONRPCRequest& request) { RPCHelpMan{"sendrawtransaction", - "\nSubmits raw transaction (serialized, hex-encoded) to local node and network.\n" + "\nSubmit a raw transaction (serialized, hex-encoded) to local node and network.\n" + "\nNote that the transaction will be sent unconditionally to all peers, so using this\n" + "for manual rebroadcast may degrade privacy by leaking the transaction's origin, as\n" + "nodes will normally not rebroadcast non-wallet transactions already in their mempool.\n" "\nAlso see createrawtransaction and signrawtransactionwithkey calls.\n", { {"hexstring", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "The hex string of the raw transaction"}, |